Commit a606df1
committed
keyviz spa: round-3 follow-ups (PR #680)
Addresses Claude bot round-2 + round-3:
- KeyViz.tsx: TimeAxis moved inside the overflow-auto scroll
container so its absolutely-positioned labels track the canvas
when the heatmap overflows horizontally. Round-2 raised this and
the round-2 commit missed it; round-3 re-flagged.
- KeyViz.tsx: drop the dead `maxValue === 0 ? 0 :` ternary in the
render loop — the v === 0 short-circuit above guarantees we
never reach that path with maxValue at zero. Add a one-line
comment explaining the invariant.
- Design doc 6 lens 3: replace the stale "single putImageData"
claim with the fillRect-per-non-zero-cell description so the
five-lens summary matches 4.3.
- Design doc 4.2: drop the route-axis-label paragraph that
described an alternative the implementation never adopted; note
the row-detail flyout supersedes it.1 parent ae956a2 commit a606df1
2 files changed
Lines changed: 18 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
171 | | - | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
172 | 175 | | |
173 | 176 | | |
174 | 177 | | |
| |||
223 | 226 | | |
224 | 227 | | |
225 | 228 | | |
226 | | - | |
227 | | - | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
228 | 232 | | |
229 | 233 | | |
230 | 234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
125 | 128 | | |
126 | 129 | | |
127 | 130 | | |
128 | 131 | | |
129 | 132 | | |
130 | | - | |
| 133 | + | |
131 | 134 | | |
132 | 135 | | |
133 | 136 | | |
| |||
163 | 166 | | |
164 | 167 | | |
165 | 168 | | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
166 | 174 | | |
167 | 175 | | |
168 | 176 | | |
169 | 177 | | |
170 | 178 | | |
171 | 179 | | |
172 | 180 | | |
| 181 | + | |
173 | 182 | | |
174 | 183 | | |
175 | | - | |
176 | 184 | | |
177 | 185 | | |
178 | 186 | | |
| |||
0 commit comments