Commit af2d12b
committed
docs(sqs/throttle): refresh stale comments on idle-evict constants
Round-3 Claude review on PR #679 caught two stale comments left over
from the runSweepLoop refactor:
throttleIdleEvictAfter said "no goroutine; lookups call sweep()
opportunistically" -- both clauses are now false (runSweepLoop is
the goroutine, hot-path charge() never calls sweep()).
throttleEvictSweepEvery said "bounds how often the sweep runs from
the hot path" -- the hot path no longer runs sweep at all; this
constant is now just the background ticker interval.
Both updated to describe the post-runSweepLoop design and to
reinforce that the sweep cost is amortised across the goroutine
ticker rather than concentrated on whichever request was unlucky
enough to trigger it (which was the old behaviour Gemini high
flagged in PR #679 round 1).1 parent c6d3a68 commit af2d12b
1 file changed
Lines changed: 10 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
80 | 82 | | |
81 | 83 | | |
82 | | - | |
83 | | - | |
84 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
85 | 88 | | |
86 | 89 | | |
87 | 90 | | |
| |||
0 commit comments