Commit b2e8c14
committed
docs(design): promote admin dashboard from _partial_ to _implemented_
Per docs/design/README.md's lifecycle convention. The original
P1–P4 plan has fully shipped:
- P1 (admin skeleton + Dynamo + AdminForward) — #634/#635/#644/#648
- P2 (S3 endpoints incl. write paths and AdminForward integration)
— #658 / #669 / #673 / #695 (TOCTOU safety net)
- P3 (React SPA + embed) — #649 / #650
- P4 (TLS / role / CSRF / operator doc / deployment runbook
/ scripts/rolling-update.sh admin support) — #674 / #669
/ #678
The AdminDeleteBucket TOCTOU caught during PR #669 review (the
last "in-flight" item that kept the doc at _partial_) is fully
resolved by the safety-net design landed in #695.
What changed:
- git mv 2026_04_24_partial_admin_dashboard.md →
2026_04_24_implemented_admin_dashboard.md (history
follows the rename)
- Header Status line: "Partial" → "Implemented", explanation
updated to reflect the post-fix state and the rationale for
promotion.
- "Last updated" bumped to 2026-04-28 with the rename trigger.
- Section heading "Outstanding open items" → "Out-of-scope
follow-ups" — the remaining three entries (criterion 5,
object browser, TLS hot-reload) are not in-flight work; they
are deferred-at-design or Non-goal items. The TOCTOU bullet
is removed (resolved) and replaced with a one-line
cross-link to the safety-net design + admin_deployment.md
§4.6 contract.
- Removed the closing "rename trigger" sentence — we just did
the rename.
- Status table: P2 row now lists #695 alongside #658/#669/#673
so a future reader can find the TOCTOU fix from the index.
- Cross-references updated everywhere the old filename
appeared:
docs/admin.md (header link + Cross-references)
docs/admin_deployment.md (header link + final cross-ref)
docs/design/2026_04_28_proposed_admin_delete_bucket_safety_net.md
(Background section pointer)
internal/admin/config.go (Section 7.1 reference comment)
No code changes other than the comment-only filename refresh in
config.go.1 parent 4e3fdb8 commit b2e8c14
5 files changed
Lines changed: 16 additions & 17 deletions
File tree
- docs
- design
- internal/admin
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
336 | 336 | | |
337 | 337 | | |
338 | 338 | | |
339 | | - | |
| 339 | + | |
340 | 340 | | |
341 | 341 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
405 | | - | |
| 405 | + | |
406 | 406 | | |
407 | 407 | | |
408 | 408 | | |
| |||
Lines changed: 9 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
| 19 | + | |
| 20 | + | |
22 | 21 | | |
23 | 22 | | |
24 | | - | |
| 23 | + | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
0 commit comments