Skip to content

Commit c42633a

Browse files
committed
docs(keyviz): refresh resolveWrite fallback comment after round-1 fix
The resolveWrite fallback path comment still said the identity is "last-touched" — but round-1's updateFallbackState fix made it the contributor that supplied fallbackMax (not the last to touch). Updated the comment to match the actual behavior; identity is (0, 0) only when every contribution was unknown-term or when an unknown-term source supplied the largest value. (Claude bot R2 LOW on PR #822 — purely cosmetic, no behavior change.)
1 parent 772a7da commit c42633a

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

internal/admin/keyviz_fanout.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -754,12 +754,14 @@ func resolveRowMergeAcc(acc *rowMergeAcc, useGroupTermDedupe bool) KeyVizRow {
754754
// across overlapping unknown/known windows.
755755
func (c *cellMergeAcc) resolveWrite() (value, group, term uint64) {
756756
if c.hasUnknownTerm {
757-
// Fallback: max-merge across all contributions; the only
758-
// identity we have for the fallback path is the
759-
// last-touched group/term (which may be 0 if every
760-
// contribution was unknown), which matches the legacy
761-
// §4.2 / PR-3b behavior the sentinel was designed to
762-
// preserve.
757+
// Fallback: max-merge across all contributions. Identity
758+
// is from the contributor that supplied fallbackMax (round-1
759+
// fix on PR #822 — updateFallbackState now stamps
760+
// lastGroup/lastTerm when value >= fallbackMax). Identity
761+
// is (0, 0) only when every contribution was unknown-term
762+
// or when an unknown-term source supplied the largest value.
763+
// Matches the legacy §4.2 / PR-3b behavior the sentinel
764+
// was designed to preserve.
763765
return c.fallbackMax, c.lastGroup, c.lastTerm
764766
}
765767
var sum, largestValue, largestGroup, largestTerm uint64

0 commit comments

Comments
 (0)