Commit d4d7ad8
authored
feat(sqs): --sqsFifoPartitionMap flag + parser + validator (Phase 3.D PR 4-A) (#704)
## Summary
Phase 3.D PR 4-A of the split-queue FIFO rollout. Operator-config
foundation: parses `--sqsFifoPartitionMap`, validates against
`--raftGroups`, plumbs through `parseRuntimeConfig` into
`runtimeConfig.sqsFifoPartitionMap`. Stacks on top of #703 (PR 3,
partitioned-keyspace constructors).
## What's added
- `--sqsFifoPartitionMap` flag with grammar
`queue.fifo:N=group_0,...,group_{N-1};...`
- `parseSQSFifoPartitionMap` + `parseSQSFifoPartitionMapEntry` (grammar
+ per-entry consistency)
- `validateSQSFifoPartitionMap` (cross-check against `--raftGroups`)
- `sqsFifoQueueRouting` struct (PartitionCount + Groups)
- `runtimeConfig.sqsFifoPartitionMap` field
## What's NOT added (deferred to PR 4-B)
- Routing layer wiring through `ShardedCoordinator`
- `htfifo` capability advertisement on `/sqs_health`
- `kv/lease_state.go` leadership-refusal hook for non-htfifo binaries
- Catalog polling for partitioned-queue discovery at startup
These are coupled by the design's "binary advertises htfifo only when
both routing AND leadership-refusal are in place" rule, so they belong
in one PR.
## Validation coverage
- PartitionCount > 0
- PartitionCount ≤ 32 (per-queue cap)
- PartitionCount must be a power of two
- `len(Groups) == PartitionCount`
- No duplicate queues across entries
- Every named group exists in `--raftGroups`
- Empty queue / empty group / trailing-comma / missing-`=` all rejected
with the offending entry quoted in the error
## Test plan
- [x] `TestParseSQSFifoPartitionMap` covers grammar, whitespace,
multiple queues, all rejection paths.
- [x] `TestValidateSQSFifoPartitionMap` covers the missing-group case
with queue + partition-index pointer.
- [x] `parseRuntimeConfig` integration: `main_bootstrap_e2e_test.go`
updated for the new parameter.
- [x] `go test -race ./adapter/... .` pass.
- [x] `golangci-lint ./...` clean.
## Self-review (per CLAUDE.md)
1. **Data loss** — config-only change. No FSM, Pebble, or retention path
is touched. No issue.
2. **Concurrency / distributed failures** — single-shot parse at
startup, no goroutines or shared state. No issue.
3. **Performance** — startup-time validation only. No hot-path effect.
No issue.
4. **Data consistency** — partition count and group list must agree at
parse time, so the runtime cannot see a half-shaped routing map. The
flag has no effect on production traffic until PR 4-B + PR 5 land. No
issue.
5. **Test coverage** — 11 sub-tests in `TestParseSQSFifoPartitionMap`
and 3 in `TestValidateSQSFifoPartitionMap`, covering every documented
rejection branch.4 files changed
Lines changed: 419 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
107 | 120 | | |
108 | 121 | | |
109 | 122 | | |
| |||
369 | 382 | | |
370 | 383 | | |
371 | 384 | | |
372 | | - | |
| 385 | + | |
373 | 386 | | |
374 | 387 | | |
375 | 388 | | |
| |||
383 | 396 | | |
384 | 397 | | |
385 | 398 | | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
394 | 408 | | |
395 | 409 | | |
396 | | - | |
| 410 | + | |
397 | 411 | | |
398 | 412 | | |
399 | 413 | | |
| |||
425 | 439 | | |
426 | 440 | | |
427 | 441 | | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
428 | 447 | | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
437 | 457 | | |
438 | 458 | | |
439 | 459 | | |
| |||
457 | 477 | | |
458 | 478 | | |
459 | 479 | | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
460 | 502 | | |
461 | 503 | | |
462 | 504 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
340 | 340 | | |
341 | 341 | | |
342 | 342 | | |
343 | | - | |
| 343 | + | |
344 | 344 | | |
345 | 345 | | |
346 | 346 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| 38 | + | |
36 | 39 | | |
37 | 40 | | |
38 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
39 | 61 | | |
40 | 62 | | |
41 | 63 | | |
| |||
133 | 155 | | |
134 | 156 | | |
135 | 157 | | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
136 | 327 | | |
137 | 328 | | |
138 | 329 | | |
| |||
0 commit comments