Skip to content

Commit db30e50

Browse files
Copilotbootjp
andauthored
fix: improve comment clarity per code review feedback
Agent-Logs-Url: https://github.com/bootjp/elastickv/sessions/7abd0211-57ab-4b16-9583-7f4c77e060cd Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
1 parent 77cebc1 commit db30e50

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

adapter/s3_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1893,8 +1893,8 @@ func TestS3Server_BackwardCompatibility_NoBucketAclFieldIsPrivate(t *testing.T)
18931893
st := store.NewMVCCStore()
18941894
coord := newLocalAdapterCoordinator(st)
18951895

1896-
// Write a legacy bucket meta JSON directly into the store without the "acl"
1897-
// field, simulating a bucket created before the ACL feature was introduced.
1896+
// Write legacy bucket metadata as JSON directly into the store without the
1897+
// "acl" field, simulating a bucket created before the ACL feature was introduced.
18981898
type legacyBucketMeta struct {
18991899
BucketName string `json:"bucket_name"`
19001900
Generation uint64 `json:"generation"`

docs/s3_public_bucket_design.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,7 @@ func (s *S3Server) resolveAuth(r *http.Request, bucket, objectKey string) *s3Aut
182182
// Check the bucket's ACL
183183
meta, err := s.loadBucketMeta(r.Context(), bucket)
184184
if err != nil || meta == nil {
185-
// If the bucket is not found, fall through to the auth flow
186-
// (NoSuchBucket is handled later in the pipeline)
185+
// If the bucket is not found, fall through to the auth flow (NoSuchBucket is handled later in the pipeline).
187186
return s.authorizeRequest(r)
188187
}
189188

0 commit comments

Comments
 (0)