Skip to content

Commit e3f09f2

Browse files
committed
fix(scripts): apply PR #926 claude[bot] nits — drop dead T1_KEY / move --host comment
- scripts/run-jepsen-m5-local.sh: T1_KEY assignment forked elastickv-route-key once per invocation but was never referenced after the shardRanges fix migrated to ":${T3_KEY}=1,${T3_KEY}:=2". Drop it. The comment block immediately below still mentions "T1_KEY" as a routing-key concept, not the bash variable, which is fine — it documents WHY group 1's range must start at empty. - Move the --host 127.0.0.1 explanation comment from after the lein run block to immediately before it, so readers see the rationale before the flag rather than scrolling past the command first.
1 parent 83d44c0 commit e3f09f2

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

scripts/run-jepsen-m5-local.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ for bin in "$ROUTE_KEY_BIN" "$LIST_ROUTES_BIN" "$BINARY"; do
9696
exit 1
9797
fi
9898
done
99-
T1_KEY="$("$ROUTE_KEY_BIN" jepsen_append_t1)"
10099
T3_KEY="$("$ROUTE_KEY_BIN" jepsen_append_t3)"
101100
# Issue #930 fix: --shardRanges must cover every routing key. Without
102101
# a [<empty>, T1_KEY) range, any table whose base64-encoded name sorts
@@ -207,6 +206,15 @@ mkdir -p tmp-home .lein
207206
# (verify-multi-group-routing!) at the workload's first setup! call.
208207
# Without them the hook falls back to PATH lookup which fails when
209208
# run from this script's tmp build.
209+
#
210+
# --host 127.0.0.1 — without this the workload's open! resolves the
211+
# DynamoDB client hostname from (name node) where node is one of
212+
# default-nodes ["n1" "n2" "n3" "n4" "n5"]; these are virtual labels,
213+
# not real hostnames, and DNS resolution fails with 'nodename nor
214+
# servname provided'. --host overrides via cli/common-cli-opts'
215+
# --host -> :host -> :dynamo-host -> make-ddb-client wiring. Required
216+
# for the single-process two-group topology this script launches —
217+
# every "node" client talks to the same loopback DynamoDB endpoint.
210218
HOME="$(pwd)/tmp-home" LEIN_HOME="$(pwd)/.lein" \
211219
LEIN_JVM_OPTS="-Duser.home=$(pwd)/tmp-home" \
212220
"$LEIN_BIN" run -m elastickv.dynamodb-multi-table-workload \
@@ -218,14 +226,6 @@ HOME="$(pwd)/tmp-home" LEIN_HOME="$(pwd)/.lein" \
218226
--list-routes-bin "$LIST_ROUTES_BIN" \
219227
--grpc-host-port "$PROC_ADDR" \
220228
|| EXIT_CODE=$?
221-
# --host 127.0.0.1 — without this the workload's open! resolves the
222-
# DynamoDB client hostname from (name node) where node is one of
223-
# default-nodes ["n1" "n2" "n3" "n4" "n5"]; these are virtual labels,
224-
# not real hostnames, and DNS resolution fails with 'nodename nor
225-
# servname provided'. --host overrides via cli/common-cli-opts'
226-
# --host -> :host -> :dynamo-host -> make-ddb-client wiring. Required
227-
# for the single-process two-group topology this script launches —
228-
# every "node" client talks to the same loopback DynamoDB endpoint.
229229

230230
EXIT_CODE=${EXIT_CODE:-0}
231231

0 commit comments

Comments
 (0)