Commit f901d70
committed
admin: refresh stale ErrTablesNotLeader sentinel comment (Claude review)
Two nit follow-ups from Claude review #4 on 87043f9:
1) The ErrTablesNotLeader sentinel's own declaration comment still
said "the future AdminForward RPC catches this as the trigger to
forward". The previous review pass updated only the writeTablesError
site comment. Refreshed the sentinel comment too: when a
LeaderForwarder is configured, tryForwardCreate / tryForwardDelete
catch this before writeTablesError; without a forwarder, the arm
maps to 503 + Retry-After:1.
2) newFollowerHandler still constructed notLeaderSource with an empty
tables map. notLeaderSource overrides AdminCreateTable /
AdminDeleteTable to unconditionally return ErrTablesNotLeader, so
the map is never consulted. The two individual tests cleaned up in
the previous commit already use bare ¬LeaderSource{}; the helper
now matches.1 parent 87043f9 commit f901d70
2 files changed
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
123 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
124 | 126 | | |
125 | 127 | | |
126 | 128 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
| |||
0 commit comments