proxy/sentry: fix exhaustive lint error in truncateValue#352
Merged
bootjp merged 3 commits intofeature/redis-proxyfrom Mar 17, 2026
Merged
proxy/sentry: fix exhaustive lint error in truncateValue#352bootjp merged 3 commits intofeature/redis-proxyfrom
bootjp merged 3 commits intofeature/redis-proxyfrom
Conversation
…stead of switch on reflect.Kind Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Redis proxy for dual-write with pub/sub forwarding
proxy/sentry: fix exhaustive lint error in truncateValue
Mar 17, 2026
| switch rv.Kind() { | ||
| case reflect.Slice, reflect.Array: | ||
| kind := rv.Kind() | ||
| if kind == reflect.Slice || kind == reflect.Array { |
Contributor
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
QF1003: could use tagged switch on kind (staticcheck)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
exhaustivelinter rejected theswitch rv.Kind()insidetruncateValuebecause it requires all 26reflect.Kindvalues to be explicitly listed as cases.Change
Replace the inner
switch rv.Kind()withif/elsecomparisons — same logic, no enum exhaustiveness requirement:📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.