Skip to content

[WIP] Implement one-phase commit for single-group transactions #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bootjp merged 3 commits into from
Mar 21, 2026
+32 −3
Merged

[WIP] Implement one-phase commit for single-group transactions #383

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a312646
Initial plan
Copilot Mar 21, 2026
241b3cf
kv: remove redundant validateConflicts call in handleOnePhaseTxnRequest
Copilot Mar 21, 2026
265e3f6
kv: add TestOnePhaseTxnDetectsWriteConflict test
Copilot Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions kv/fsm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,6 @@ func (f *kvFSM) handleOnePhaseTxnRequest(ctx context.Context, r *pb.Request, com
if err != nil {
return err
}
if err := f.validateConflicts(ctx, uniq, startTS); err != nil {
return errors.WithStack(err)
}

storeMuts, err := f.buildOnePhaseStoreMutations(ctx, uniq)
if err != nil {
Expand Down
Loading