Skip to content

ci: remove Claude Code OAuth diagnostic steps#699

Closed
bootjp wants to merge 1 commit intomainfrom
ci/remove-claude-action-diag
Closed

ci: remove Claude Code OAuth diagnostic steps#699
bootjp wants to merge 1 commit intomainfrom
ci/remove-claude-action-diag

Conversation

@bootjp
Copy link
Copy Markdown
Owner

@bootjp bootjp commented Apr 28, 2026

Summary

Remove the temporary OAuth diagnostic steps added in #698. They isolated the failure as intended — the Run Claude Code step is fine on this side and the bug is upstream.

Diagnostic outcome (run 25057882769)

Step Result Meaning
Install Claude CLI for diag runner can fetch / install the CLI
Verify OAuth on the runner on the same runner, with the same token via env, claude --print "ok" returns a normal Claude response
Run Claude Code (action / agent SDK) same token, same env, throws Could not resolve [authentication]

So the failing path is only through anthropics/claude-code-action@anthropic-ai/claude-agent-sdk's child-process auth forwarding. The token, the Anthropic OAuth backend, the runner network, and step-level env propagation are all healthy.

Changes

  • Drop both diag steps (Install Claude CLI for diag + Verify OAuth on the runner).
  • Replace the comment block on Run Claude Code to record the diagnostic conclusion and the workarounds that did NOT help, so the next person doesn't redo the same investigation.

Kept as-is (deliberately)

  • uses: ...@<v1.0.107 SHA> pin
  • duplicated env: CLAUDE_CODE_OAUTH_TOKEN on the step

Neither fixes the issue, but reverting them now is churn we would undo again when upstream ships a fix. Lift both in a single follow-up at that point.

Operational follow-ups (out of scope for this PR)

  • Rotate CLAUDE_CODE_OAUTH_TOKEN (insurance, since the diag step did briefly carry the token through pbpaste | docker stdin in local testing too — the run logs themselves did not leak it).
  • File an upstream issue against anthropics/claude-code-action with run 25057882769 as the minimal repro. Not done in this PR; can be a separate task.
  • If @claude review recovery is urgent before upstream fixes things, switch to ANTHROPIC_API_KEY auth (separate billing). Also out of scope here.

Test plan

  • After merge, @claude on a PR will continue to fail until upstream fixes the SDK auth forwarding. That is the expected state — the workflow file is back to its pre-diagnostic shape and waiting.

Self-review

CI workflow only. 5-lens collapses to: no data-loss / concurrency / consistency / perf surface. Test coverage N/A (this is the workflow that runs review tooling, not code). Reverts a known-good prior state (apart from the comment refresh).

The diagnostic added in #698 has done its job. Run 25057882769 isolated
the failure: on the same runner, in the same job, with the same OAuth
token, `claude --print` (CLI direct) authenticated and got a normal
response, while `Run Claude Code` (via the agent SDK) threw
`Could not resolve [authentication]`. So the bug is upstream in
anthropics/claude-code-action / @anthropic-ai/claude-agent-sdk; nothing
on our side can fix it. Remove the diagnostic and update the inline
comment on the action step to record the conclusion and the workarounds
that did NOT help, so the next person doesn't redo the work.

Pin and env: duplication on the action step are kept as-is — they don't
fix the issue but cost nothing, and reverting them now is just churn we
would undo again when upstream ships a fix.
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@bootjp has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 16 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 340590f9-22c9-4576-8b0c-69aed6bf79f1

📥 Commits

Reviewing files that changed from the base of the PR and between 25ec963 and f9f9528.

📒 Files selected for processing (1)
  • .github/workflows/claude.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/remove-claude-action-diag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bootjp
Copy link
Copy Markdown
Owner Author

bootjp commented Apr 28, 2026

Superseded by #700, which installed the Claude Code GitHub App and replaced this workflow on main. The original failure during 04-28 was actually intermittent App install/uninstall on the repo (not an upstream regression as this PR's body theorized). Closing.

@bootjp bootjp closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant