REST: add atime support

Co-authored-by: Junie <junie@jetbrains.com>

Author: ThomasWaldmann

src/borgstore/backends/rest.py

@@ -379,8 +379,9 @@ def info(self, name: str) -> ItemInfo:
             self._handle_response(response, name)  # raises!
         exists = response.status_code == HTTP.OK
         is_dir = response.headers.get("X-BorgStore-Is-Directory") == "true"
+        atime = float(response.headers.get("X-BorgStore-Atime", 0))
         size = int(response.headers.get("Content-Length", 0)) if exists else 0
-        return ItemInfo(name=name, exists=exists, size=size, directory=is_dir)
+        return ItemInfo(name=name, exists=exists, size=size, directory=is_dir, atime=atime)
 
     def load(self, name: str, *, size=None, offset=0) -> bytes:
         self._assert_open()
@@ -464,4 +465,10 @@ def list(self, name: str) -> Iterator[ItemInfo]:
         response = self._request("get", self._url(name) + "/")  # trailing "/" needed to get list
         self._handle_response(response, name)
         for entry in response.json():
-            yield ItemInfo(name=entry["name"], exists=True, size=entry["size"], directory=entry.get("directory", False))
+            yield ItemInfo(
+                name=entry["name"],
+                exists=True,
+                size=entry["size"],
+                directory=entry.get("directory", False),
+                atime=entry.get("atime", 0),
+            )

src/borgstore/server/rest.py

@@ -306,6 +306,7 @@ def do_HEAD(self):
                 headers={
                     "Content-Length": str(info.size),
                     "X-BorgStore-Is-Directory": "true" if info.directory else "false",
+                    "X-BorgStore-Atime": str(info.atime),
                 },
             )
         except Exception as e:
@@ -320,7 +321,7 @@ def do_GET(self):
                 # [{"name": "...", "size": ...}, ...]
                 with self.server.backend:
                     items = (
-                        {"name": item.name, "size": item.size, "directory": item.directory}
+                        {"name": item.name, "size": item.size, "directory": item.directory, "atime": item.atime}
                         for item in self.server.backend.list(self.name)
                     )
                     json_data = json.dumps(list(items), indent=2)

tests/test_rest_url.py

@@ -22,6 +22,13 @@ def test_rest_url_info(tmp_path):
         info = store.info(item_name)
         assert info.exists
         assert info.size == len(item_data)
+        assert info.atime > 0
+
+        # Test listing
+        items = list(store.list(""))
+        assert len(items) == 1
+        assert items[0].name == item_name
+        assert items[0].atime > 0
 
         # Test nonexistent item
         # This also used to hang if it returned a 404 with a body.

tests/test_server_rest.py

@@ -617,31 +617,32 @@ def do_request(method, path, body=b""):
         resp_body = b""
         if method.upper() != "HEAD" and "Content-Length" in resp_headers:
             resp_body = proc.stdout.read(int(resp_headers["Content-Length"]))
-        return status, resp_body
+        return status, resp_body, resp_headers
 
     try:
         # 1. Create store
-        status, body = do_request("POST", "/?cmd=create")
+        status, body, headers = do_request("POST", "/?cmd=create")
         assert status == 200
 
         # 2. Store something
         item_data = b"stdio data"
-        status, body = do_request("POST", "/item1", body=item_data)
+        status, body, headers = do_request("POST", "/item1", body=item_data)
         assert status == 200
 
         # 3. List the store
-        status, body = do_request("GET", "/")
+        status, body, headers = do_request("GET", "/")
         assert status == 200
         items = json.loads(body.decode("utf-8"))
-        assert any(item["name"] == "item1" for item in items)
+        assert any(item["name"] == "item1" and item.get("atime", 0) > 0 for item in items)
 
         # 4. Info (HEAD)
-        status, body = do_request("HEAD", "/item1")
+        status, body, headers = do_request("HEAD", "/item1")
         assert status == 200
         assert body == b""
+        assert float(headers.get("X-BorgStore-Atime", 0)) > 0
 
         # 5. Info for nonexistent (HEAD)
-        status, body = do_request("HEAD", "/nonexistent")
+        status, body, headers = do_request("HEAD", "/nonexistent")
         assert status == 404
         assert body == b""