refactor: use internal base64 utils

Author: RomainLanz

src/base64.ts

@@ -5,10 +5,8 @@
  * @copyright Boring Node
  */
 
-export function base64UrlEncode(
-  data: ArrayBuffer | SharedArrayBuffer | Uint8Array | Buffer
-): string {
-  const buffer = Buffer.from(data as any)
+export function base64UrlEncode(data: Uint8Array | Buffer | string): string {
+  const buffer = Buffer.from(data)
 
   return buffer.toString('base64').replace(/\+/g, '-').replace(/\//g, '_').replace(/=+$/, '')
 }

src/message_verifier.ts

@@ -6,7 +6,8 @@
  */
 
 import { createHash } from 'node:crypto'
-import { base64, MessageBuilder, RuntimeException } from '@poppinss/utils'
+import { MessageBuilder, RuntimeException } from '@poppinss/utils'
+import { base64UrlEncode, base64UrlDecode } from './base64.ts'
 import { Hmac } from './hmac.ts'
 
 /**
@@ -52,7 +53,7 @@ export class MessageVerifier {
       throw new RuntimeException(`Cannot sign "${payload}" value`)
     }
 
-    const encoded = base64.urlEncode(new MessageBuilder().build(payload, expiresIn, purpose))
+    const encoded = base64UrlEncode(new MessageBuilder().build(payload, expiresIn, purpose))
     return `${encoded}${this.#separator}${new Hmac(this.#cryptoKey).generate(encoded)}`
   }
 
@@ -75,7 +76,7 @@ export class MessageVerifier {
     /**
      * Ensure value can be decoded
      */
-    const decoded = base64.urlDecode(encoded, undefined, false)
+    const decoded = base64UrlDecode(encoded, 'utf8')
     if (!decoded) {
       return null
     }

tests/message_verifier.spec.ts

@@ -6,8 +6,8 @@
  */
 
 import { test } from '@japa/runner'
-import { base64 } from '@poppinss/utils'
 import { MessageVerifier } from '../src/message_verifier.js'
+import { base64UrlDecode } from '../src/base64.ts'
 
 const SECRET = 'averylongradom32charactersstring'
 
@@ -23,15 +23,15 @@ test.group('MessageVerifier', () => {
     const messageVerifier = new MessageVerifier(SECRET)
     const signed = messageVerifier.sign({ username: 'virk' })
 
-    assert.equal(base64.urlDecode(signed.split('.')[0]), '{"message":{"username":"virk"}}')
+    assert.equal(base64UrlDecode(signed.split('.')[0], 'utf8'), '{"message":{"username":"virk"}}')
   })
 
   test('sign an object with purpose', ({ assert }) => {
     const messageVerifier = new MessageVerifier(SECRET)
     const signed = messageVerifier.sign({ username: 'virk' }, undefined, 'login')
 
     assert.equal(
-      base64.urlDecode(signed.split('.')[0]),
+      base64UrlDecode(signed.split('.')[0], 'utf8'),
       '{"message":{"username":"virk"},"purpose":"login"}'
     )
   })