fix(queue-manager): destroy cached adapters before reinit

Author: RomainLanz

src/queue_manager.ts

@@ -87,6 +87,11 @@ class QueueManagerSingleton {
 
     this.#validateConfig(config)
 
+    for (const [name, adapter] of this.#adapterInstances) {
+      debug('destroying adapter "%s" before reinitialization', name)
+      await adapter.destroy()
+    }
+
     this.#adapterInstances.clear()
 
     this.#defaultAdapter = config.default

tests/queue_manager.spec.ts

@@ -3,6 +3,7 @@ import * as errors from '../src/exceptions.js'
 import { QueueManager } from '../src/queue_manager.js'
 import { sync } from '../src/drivers/sync_adapter.js'
 import { MemoryLogger } from './_mocks/memory_logger.js'
+import type { Adapter } from '../src/contracts/adapter.js'
 
 test.group('QueueManager', () => {
   test('should validate adapter presence', async ({ assert }) => {
@@ -166,4 +167,75 @@ test.group('QueueManager', () => {
 
     await QueueManager.destroy()
   })
+
+  test('should destroy existing adapter instances before reinitializing', async ({
+    assert,
+    cleanup,
+  }) => {
+    const adapters: Adapter[] = []
+    let destroyedCount = 0
+
+    const createAdapter = (): Adapter => ({
+      setWorkerId() {},
+      pop: async () => null,
+      popFrom: async () => null,
+      recoverStalledJobs: async () => 0,
+      completeJob: async () => {},
+      failJob: async () => {},
+      retryJob: async () => {},
+      getJob: async () => null,
+      push: async () => {},
+      pushOn: async () => {},
+      pushLater: async () => {},
+      pushLaterOn: async () => {},
+      pushMany: async () => {},
+      pushManyOn: async () => {},
+      size: async () => 0,
+      sizeOf: async () => 0,
+      destroy: async () => {
+        destroyedCount++
+      },
+      upsertSchedule: async () => 'schedule-id',
+      createSchedule: async () => 'schedule-id',
+      getSchedule: async () => null,
+      listSchedules: async () => [],
+      updateSchedule: async () => {},
+      deleteSchedule: async () => {},
+      claimDueSchedule: async () => null,
+    })
+
+    cleanup(async () => {
+      await QueueManager.destroy()
+    })
+
+    await QueueManager.init({
+      default: 'custom',
+      adapters: {
+        custom: () => {
+          const adapter = createAdapter()
+          adapters.push(adapter)
+          return adapter
+        },
+      },
+    })
+
+    const firstAdapter = QueueManager.use()
+
+    await QueueManager.init({
+      default: 'custom',
+      adapters: {
+        custom: () => {
+          const adapter = createAdapter()
+          adapters.push(adapter)
+          return adapter
+        },
+      },
+    })
+
+    const secondAdapter = QueueManager.use()
+
+    assert.strictEqual(firstAdapter, adapters[0])
+    assert.strictEqual(secondAdapter, adapters[1])
+    assert.equal(destroyedCount, 1)
+  })
 })