fix: improve error handling in QueueManager

Author: RomainLanz

src/exceptions.ts

@@ -44,3 +44,21 @@ export const E_JOB_TIMEOUT = createError<[jobName: string, timeout: number]>(
   'The job "%s" has exceeded the timeout of %dms',
   'E_JOB_TIMEOUT'
 )
+
+export const E_QUEUE_NOT_INITIALIZED = createError(
+  'QueueManager is not initialized. Call QueueManager.init() before using it.',
+  'E_QUEUE_NOT_INITIALIZED',
+  500
+)
+
+export const E_ADAPTER_INIT_ERROR = createError<[adapterName: string, originalMessage: string]>(
+  'Failed to initialize adapter "%s". Reason: %s',
+  'E_ADAPTER_INIT_ERROR',
+  500
+)
+
+export const E_NO_JOBS_FOUND = createError<[patterns: string]>(
+  'No jobs found for the specified locations: %s. Verify your glob patterns match your job files.',
+  'E_NO_JOBS_FOUND',
+  500
+)

src/locator.ts

@@ -14,7 +14,9 @@ class LocatorSingleton {
     this.#registry.set(name, JobClass)
   }
 
-  async registerFromGlob(patterns: string[]) {
+  async registerFromGlob(patterns: string[]): Promise<number> {
+    let registered = 0
+
     for (const pattern of patterns) {
       debug('registering jobs from glob pattern: %s', pattern)
       for await (const file of glob(pattern)) {
@@ -27,12 +29,15 @@ class LocatorSingleton {
 
           if (JobClass && typeof JobClass === 'function' && JobClass.name) {
             this.register(JobClass.name, JobClass)
+            registered++
           }
         } catch (error) {
           console.warn(`Failed to load job from ${file}:`, error)
         }
       }
     }
+
+    return registered
   }
 
   get<T extends Job = Job>(name: string): JobClass<T> | undefined {

src/queue_manager.ts

@@ -6,6 +6,7 @@ import type { Adapter } from './contracts/adapter.js'
 import type { AdapterFactory, QueueConfig, QueueManagerConfig, RetryConfig } from './types/main.js'
 
 class QueueManagerSingleton {
+  #initialized = false
   #defaultAdapter!: string
   #adapters: Record<string, AdapterFactory> = {}
   #adapterInstances: Map<string, Adapter> = new Map()
@@ -32,13 +33,26 @@ class QueueManagerSingleton {
     }
 
     if (config.locations && config.locations.length > 0) {
-      await Locator.registerFromGlob(config.locations)
+      const registered = await Locator.registerFromGlob(config.locations)
+
+      if (registered === 0) {
+        this.#logger.warn(
+          `No jobs found for locations: ${config.locations.join(', ')}. ` +
+            'Verify your glob patterns match your job files.'
+        )
+      }
     }
 
+    this.#initialized = true
+
     return this
   }
 
   use(adapter?: string): Adapter {
+    if (!this.#initialized) {
+      throw new errors.E_QUEUE_NOT_INITIALIZED()
+    }
+
     if (!adapter) {
       adapter = this.#defaultAdapter
     }
@@ -62,9 +76,8 @@ class QueueManagerSingleton {
       this.#adapterInstances.set(adapter, instance)
       return instance
     } catch (error) {
-      // TODO: Improve error handling
-      throw new Error()
-      // throw new errors.E_ADAPTER_ERROR(`Failed to initialize adapter "${adapter}"`, error as Error)
+      const message = error instanceof Error ? error.message : String(error)
+      throw new errors.E_ADAPTER_INIT_ERROR([adapter, message])
     }
   }
 
@@ -115,6 +128,7 @@ class QueueManagerSingleton {
       await adapter.destroy()
     }
     this.#adapterInstances.clear()
+    this.#initialized = false
   }
 }