Skip to content

Commit 164d120

Browse files
committed
Rename internal modules and replace "from _ import _" statements
This also avoids having both a module named "escape_codes" and a dict named "escape_codes" in the same top-level module.
1 parent 4dc03c6 commit 164d120

4 files changed

Lines changed: 8 additions & 12 deletions

File tree

colorlog/__init__.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
import sys
44
import warnings
55

6-
from colorlog.colorlog import (
7-
escape_codes,
6+
from colorlog.formatter import (
87
default_log_colors,
98
ColoredFormatter,
109
LevelFormatter,
@@ -28,7 +27,6 @@
2827
__all__ = (
2928
"ColoredFormatter",
3029
"default_log_colors",
31-
"escape_codes",
3230
"basicConfig",
3331
"root",
3432
"getLogger",
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@
55
import sys
66
import typing
77

8-
from colorlog.escape_codes import escape_codes, parse_colors
8+
import colorlog.escape_codes
99

1010
__all__ = (
11-
"escape_codes",
1211
"default_log_colors",
1312
"ColoredFormatter",
1413
"LevelFormatter",
@@ -128,7 +127,7 @@ def _escape_code_map(self, item: str) -> EscapeCodes:
128127
129128
If _blank_escape_codes() returns True, all values will be an empty string.
130129
"""
131-
codes = {**escape_codes}
130+
codes = {**colorlog.escape_codes.escape_codes}
132131
codes.setdefault("log_color", self._get_escape_code(self.log_colors, item))
133132
for name, colors in self.secondary_log_colors.items():
134133
codes.setdefault("%s_log_color" % name, self._get_escape_code(colors, item))
@@ -152,7 +151,7 @@ def _blank_escape_codes(self):
152151
@staticmethod
153152
def _get_escape_code(log_colors: LogColors, item: str) -> str:
154153
"""Extract a color sequence from a mapping, and return escape codes."""
155-
return parse_colors(log_colors.get(item, ""))
154+
return colorlog.escape_codes.parse_colors(log_colors.get(item, ""))
156155

157156
def _append_reset(self, message: str, escapes: EscapeCodes) -> str:
158157
"""Add a reset code to the end of the message, if it's not already there."""

colorlog/logging.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44
import logging
55
import typing
66

7-
from colorlog.colorlog import ColoredFormatter, LogColors, SecondaryLogColors
7+
import colorlog.formatter
88

99
BASIC_FORMAT = "%(log_color)s%(levelname)s%(reset)s:%(name)s:%(message)s"
1010

1111

1212
def basicConfig(
1313
style: str = "%",
14-
log_colors: typing.Optional[LogColors] = None,
14+
log_colors: typing.Optional[colorlog.formatter.LogColors] = None,
1515
reset: bool = True,
16-
secondary_log_colors: typing.Optional[SecondaryLogColors] = None,
16+
secondary_log_colors: typing.Optional[colorlog.formatter.SecondaryLogColors] = None,
1717
format: str = BASIC_FORMAT,
1818
datefmt: typing.Optional[str] = None,
1919
**kwargs
@@ -24,7 +24,7 @@ def basicConfig(
2424
try:
2525
handler = logging.root.handlers[0]
2626
handler.setFormatter(
27-
ColoredFormatter(
27+
colorlog.formatter.ColoredFormatter(
2828
fmt=format,
2929
datefmt=datefmt,
3030
style=style,

colorlog/tests/test_exports.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ def test_exports():
77
assert {
88
"ColoredFormatter",
99
"default_log_colors",
10-
"escape_codes",
1110
"basicConfig",
1211
"root",
1312
"getLogger",

0 commit comments

Comments
 (0)