Fix linter issues

Author: SerafimArts

src/Action/AssemblyAction.php

@@ -8,6 +8,7 @@
 
 /**
  * @template TStatus of \UnitEnum
+ *
  * @template-implements ActionInterface<TStatus>
  */
 abstract readonly class AssemblyAction implements ActionInterface

src/Action/ClearBuildAssemblyDirectoryAction.php

@@ -18,6 +18,7 @@ public function process(Configuration $config): iterable
         $directory = $this->assembly->getBuildDirectory($config);
 
         if (\is_dir($directory)) {
+            /** @var \SplFileInfo $file */
             foreach ($this->getIterator($directory) as $file) {
                 if ($file->isDir()) {
                     yield $file->getPathname() => ClearBuildAssemblyDirectoryStatus::Cleaning;
@@ -41,7 +42,7 @@ public function process(Configuration $config): iterable
     }
 
     /**
-     * @return \RecursiveIteratorIterator<array-key, \SplFileInfo>
+     * @return \RecursiveIteratorIterator<\RecursiveDirectoryIterator>
      */
     private function getIterator(string $directory): \RecursiveIteratorIterator
     {

src/Action/CompileAction.php

@@ -21,7 +21,15 @@ public function process(Configuration $config): iterable
 
         $targetPathname = $this->getBinaryTargetPathname($config);
 
-        $targetStream = \fopen($targetPathname, 'wb+');
+        $targetStream = @\fopen($targetPathname, 'wb+');
+
+        if ($targetStream === false) {
+            throw new \RuntimeException(\sprintf(
+                'Unable to create target binary "%s"',
+                $targetPathname,
+            ));
+        }
+
         \flock($targetStream, \LOCK_EX);
 
         $this->appendSfxArchive($targetStream);
@@ -51,7 +59,15 @@ private function getBinaryTargetPathname(Configuration $config): string
      */
     private function appendSource(mixed $stream, Configuration $config): void
     {
-        $sourceStream = \fopen($config->pharPathname, 'rb');
+        $sourceStream = @\fopen($config->pharPathname, 'rb');
+
+        if ($sourceStream === false) {
+            throw new \RuntimeException(\sprintf(
+                'Unable to open application phar file "%s"',
+                $config->pharPathname,
+            ));
+        }
+
         \flock($sourceStream, \LOCK_SH);
 
         \stream_copy_to_stream($sourceStream, $stream);
@@ -78,7 +94,15 @@ private function appendSfxArchive(mixed $stream): void
     {
         $archive = $this->getSfxArchivePathname($this->assembly);
 
-        $archiveStream = \fopen($archive, 'rb');
+        $archiveStream = @\fopen($archive, 'rb');
+
+        if ($archiveStream === false) {
+            throw new \RuntimeException(\sprintf(
+                'Unable to open application SFX file "%s"',
+                $archive,
+            ));
+        }
+
         \flock($archiveStream, \LOCK_SH);
 
         \stream_copy_to_stream($archiveStream, $stream);

src/Action/CreateBoxConfigAction.php

@@ -26,6 +26,12 @@ public function process(Configuration $config): iterable
         yield CreateBoxConfigStatus::Created;
     }
 
+    /**
+     * @return list<array{
+     *     name?: non-empty-string,
+     *     in?: non-empty-string
+     * }>
+     */
     private function getBoxFinderConfig(Configuration $config): array
     {
         $finder = [];
@@ -53,6 +59,9 @@ private function getBoxFinderConfig(Configuration $config): array
         return $finder;
     }
 
+    /**
+     * @return list<non-empty-string>
+     */
     private function getBoxFilesConfig(Configuration $config): array
     {
         $files = [];
@@ -68,6 +77,9 @@ private function getBoxFilesConfig(Configuration $config): array
         return $files;
     }
 
+    /**
+     * @return list<non-empty-string>
+     */
     private function getBoxDirectoriesConfig(Configuration $config): array
     {
         $directories = [];
@@ -83,6 +95,9 @@ private function getBoxDirectoriesConfig(Configuration $config): array
         return $directories;
     }
 
+    /**
+     * @return array<non-empty-string, mixed>
+     */
     private function getBoxConfig(Configuration $config): array
     {
         $finder = $this->getBoxFinderConfig($config);

src/Action/CreateBoxStubAction.php

@@ -18,7 +18,7 @@ public function process(Configuration $config): iterable
         $stub = \str_replace(
             search: ['{name}', '{entrypoint}'],
             replace: [$config->name, $config->entrypoint],
-            subject: \file_get_contents(__DIR__ . '/../../resources/stub.php'),
+            subject: (string) @\file_get_contents(__DIR__ . '/../../resources/stub.php'),
         );
 
         \file_put_contents($config->boxStubPathname, $stub);

src/Action/DownloadBoxAction.php

@@ -28,7 +28,15 @@ public function process(Configuration $config): iterable
             return yield DownloadBoxStatus::Complete;
         }
 
-        $localBoxStream = \fopen($config->boxPharPathname, 'w+b');
+        $localBoxStream = @\fopen($config->boxPharPathname, 'w+b');
+
+        if ($localBoxStream === false) {
+            throw new \RuntimeException(\sprintf(
+                'Unable to create humbug/box phar package in "%s"',
+                $config->boxPharPathname,
+            ));
+        }
+
         \flock($localBoxStream, \LOCK_EX);
 
         try {

src/Assembly/Assembly.php

@@ -4,10 +4,10 @@
 
 namespace Boson\Component\Compiler\Assembly;
 
+use Boson\Component\Compiler\Assembly\EditionInterface as PhpEditionInterface;
 use Boson\Component\Compiler\Configuration;
 use Boson\Component\CpuInfo\ArchitectureInterface as CpuArchitectureInterface;
 use Boson\Component\OsInfo\FamilyInterface as OsFamilyInterface;
-use Boson\Component\Compiler\Assembly\EditionInterface as PhpEditionInterface;
 
 final readonly class Assembly implements \Stringable
 {

src/Assembly/AssemblyCollection.php

@@ -19,18 +19,6 @@ final class AssemblyCollection implements \IteratorAggregate, \Countable
      */
     private array $assemblies;
 
-    /**
-     * @phpstan-type OSFamilyType non-empty-string
-     * @phpstan-type CPUArchitectureType non-empty-string
-     * @phpstan-type PHPEditionType non-empty-string
-     * @phpstan-type FrontendBinaryType non-empty-string
-     * @phpstan-type BackendBinaryType non-empty-string
-     *
-     * @var array<OSFamilyType, array<CPUArchitectureType, array<PHPEditionType, array{
-     *     FrontendBinaryType,
-     *     BackendBinaryType
-     * }>>>
-     */
     private const array BUILTIN_ASSEMBLIES = [
         'linux' => [
             'arm64' => [
@@ -60,6 +48,9 @@ final class AssemblyCollection implements \IteratorAggregate, \Countable
         ],
     ];
 
+    /**
+     * @param iterable<mixed, Assembly> $assemblies
+     */
     public function __construct(iterable $assemblies)
     {
         $this->assemblies = \iterator_to_array($assemblies, false);

src/Assembly/Edition.php

@@ -30,6 +30,8 @@
 
     /**
      * @api
+     *
+     * @param non-empty-string $name
      */
     public static function tryFrom(string $name): ?BuiltinEdition
     {
@@ -38,6 +40,8 @@ public static function tryFrom(string $name): ?BuiltinEdition
 
     /**
      * @api
+     *
+     * @param non-empty-string $name
      */
     public static function from(string $name): EditionInterface
     {
@@ -46,6 +50,7 @@ public static function from(string $name): EditionInterface
 
     /**
      * @api
+     *
      * @return non-empty-list<EditionInterface>
      */
     public static function cases(): array

src/Assembly/Edition/BuiltinEdition.php

@@ -8,7 +8,7 @@
 use Boson\Component\Compiler\Assembly\EditionInterface;
 
 /**
- * @internal this is an internal library class, please do not use it in your code.
+ * @internal this is an internal library class, please do not use it in your code
  * @psalm-internal Boson\Component\Compiler\Assembly
  */
 final readonly class BuiltinEdition implements EditionInterface