Skip to content

Commit b871e6a

Browse files
fix: rename botanu.outcome attribute to botanu.outcome.status
Aligns span attribute naming with decorators.py and log records which already use botanu.outcome.status. Also removes developer-deborah from CI branch triggers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0caebfa commit b871e6a

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ name: CI
55

66
on:
77
push:
8-
branches: [main, developer-deborah]
8+
branches: [main]
99
pull_request:
1010
branches: [main]
1111

docs/tracking/outcomes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ Outcomes are recorded as span attributes:
268268

269269
| Attribute | Description |
270270
|-----------|-------------|
271-
| `botanu.outcome` | Status (success/partial/failed/timeout/canceled/abandoned) |
271+
| `botanu.outcome.status` | Status (success/partial/failed/timeout/canceled/abandoned) |
272272
| `botanu.outcome.value_type` | What was achieved |
273273
| `botanu.outcome.value_amount` | Quantified value |
274274
| `botanu.outcome.confidence` | Confidence score |

src/botanu/sdk/span_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def emit_outcome(
6363

6464
span = trace.get_current_span()
6565

66-
span.set_attribute("botanu.outcome", status)
66+
span.set_attribute("botanu.outcome.status", status)
6767

6868
if value_type:
6969
span.set_attribute("botanu.outcome.value_type", value_type)

tests/unit/test_span_helpers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def test_emit_success_outcome(self, memory_exporter):
2020

2121
spans = memory_exporter.get_finished_spans()
2222
attrs = dict(spans[0].attributes)
23-
assert attrs.get("botanu.outcome") == "success"
23+
assert attrs.get("botanu.outcome.status") == "success"
2424

2525
def test_emit_failure_outcome(self, memory_exporter):
2626
tracer = trace.get_tracer("test")
@@ -29,7 +29,7 @@ def test_emit_failure_outcome(self, memory_exporter):
2929

3030
spans = memory_exporter.get_finished_spans()
3131
attrs = dict(spans[0].attributes)
32-
assert attrs.get("botanu.outcome") == "failed"
32+
assert attrs.get("botanu.outcome.status") == "failed"
3333
assert attrs.get("botanu.outcome.reason") == "timeout"
3434

3535
def test_emit_outcome_with_value(self, memory_exporter):
@@ -43,7 +43,7 @@ def test_emit_outcome_with_value(self, memory_exporter):
4343

4444
spans = memory_exporter.get_finished_spans()
4545
attrs = dict(spans[0].attributes)
46-
assert attrs.get("botanu.outcome") == "success"
46+
assert attrs.get("botanu.outcome.status") == "success"
4747
assert attrs.get("botanu.outcome.value_type") == "tickets_resolved"
4848
assert attrs.get("botanu.outcome.value_amount") == 5.0
4949

0 commit comments

Comments
 (0)