AUTO-142 -- linting#1
Merged
Merged
Conversation
scheunemann
requested review from
a team,
choppergrip,
doisyg and
jayyoung
and removed request for
a team and
choppergrip
scheunemann
force-pushed
the
AUTO-142_linting
branch
from
b43a827 to
79012c7
Compare
scheunemann
force-pushed
the
AUTO-142_linting
branch
from
79012c7 to
d82f633
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply makes the linter pass. I also did the lining for the example
CMakeFiles.txts simply becauseament_cmake_lintdoesn't yet listen to file excludes (I think).colcon build && colcon testshould pass without test failures like here.(also added it upstream RoboSense-LiDAR#2)