execute the signal better

Signed-off-by: Robert Landers <landers.robert@gmail.com>

Author: withinboredom

src/Proxy/SpyProxy.php

@@ -71,11 +71,12 @@ function (ReflectionParameter $param) {
                 $value = '[]';
             }
             $hookName = str_replace('$', '\$', $hookName);
+
             return <<<EOT
                 {$name} {
                   \$this->operation = "{$hookName}";
                   \$this->arguments = {$value};
-                  throw new \Exception('Not implemented');
+                  throw new \Bottledcode\DurablePhp\Proxy\SpyException('do not call outside of context');
                 }
                 EOT;
         }
@@ -84,7 +85,7 @@ function (ReflectionParameter $param) {
             public function {$name}({$params}){$return} {
                 \$this->operation = "{$name}";
                 \$this->arguments = func_get_args();
-                throw new \Exception('Not implemented');
+                throw new \Bottledcode\DurablePhp\Proxy\SpyException('do not call outside of context');
             }
             EOT;
     }
@@ -102,7 +103,24 @@ protected function impureSignal(ReflectionMethod $method): string
     protected function preamble(ReflectionClass $class): string
     {
         return <<<'EOT'
-            public function __construct(private string|null &$operation = null, private array|null &$arguments = null) {}
+            private string|null $operation {
+              get => $this->op;
+              set {
+                if ($this->op !== null) {
+                  throw new \LogicException('Can only send one signal at a time');
+                }
+              }
+            }
+            private array|null $arguments {
+              get => $this->args;
+              set {
+                if ($this->args !== null) {
+                  throw new \LogicException('Can only send one signal at a time');
+                }
+              }
+            }
+            
+            public function __construct(private string|null &$op = null, private array|null &$args = null) {}
             EOT;
     }
 }

src/RemoteEntityClient.php

@@ -26,6 +26,7 @@
 
 use Amp\Http\Client\HttpClient;
 use Amp\Http\Client\Request;
+use Bottledcode\DurablePhp\Proxy\SpyException;
 use Bottledcode\DurablePhp\Proxy\SpyProxy;
 use Bottledcode\DurablePhp\Search\EntityFilter;
 use Bottledcode\DurablePhp\State\EntityId;
@@ -37,7 +38,6 @@
 use Generator;
 use Override;
 use ReflectionFunction;
-use Throwable;
 
 class RemoteEntityClient implements EntityClientInterface
 {
@@ -84,8 +84,8 @@ public function signal(EntityId|string $entityId, Closure $signal): void
         try {
             $class = new $spy($operationName, $arguments);
             $signal($class);
-        } catch (Throwable) {
-            // spies always throw
+        } catch (SpyException) {
+            // we have completed the spy
         }
         $this->signalEntity(
             is_string($entityId) ? EntityId($interfaceName, $entityId) : $entityId,