feat(container-registry): add configurable capabilities to RegistryMi…#134
Open
tim-mcdonald wants to merge 1 commit into
Open
feat(container-registry): add configurable capabilities to RegistryMi…#134tim-mcdonald wants to merge 1 commit into
tim-mcdonald wants to merge 1 commit into
Conversation
…rrorV1 Adds RegistryMirrorCapabilityV1 enum (pull/resolve/push) and an optional capabilities field to RegistryMirrorV1. Unknown values are rejected at deserialization time. Defaults to None so existing configs are unaffected. Updates CHANGELOG with unreleased entry. Closes: bottlerocket-os/bottlerocket#4710
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
RegistryMirrorCapabilityV1enum (pull,resolve,push) and an optionalcapabilitiesfield toRegistryMirrorV1, enabling per-mirror capability configuration for containerd registry mirrors.Previously, consumers of this model (e.g.
thar-be-registriesinbottlerocket-core-kit) had to hardcode capabilities for all mirrors. This blocked tools like Spegel that requirepull-only mirrors. containerd 2.1's transfer service fails when Spegel's DHT hasn't initialized ifresolveis also requested.When
capabilitiesis absent, consumers default to["pull", "resolve"]for backward compatibility. Unknown values are rejected at serde deserialization time.A companion PR in
bottlerocket-core-kitupdatesthar-be-registriesand the registry template to read and emit this field.Related Issues
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.