testsys: Update to 0.0.17#995
Merged
Merged
Conversation
zongzhidanielhu
force-pushed
the
0.0.17
branch
4 times, most recently
from
13725d1 to
b459ffa
Compare
yeazelm
reviewed
Jun 5, 2025
|
|
||
| - For EKS clusters, this can be accomplished by replacing the `clusterName`, `region`, and `version` fields with an `encodedConfig` field in the EKS cluster config. | ||
| This field's value should be a string representing a base64-encoded EKS cluster config, an example of which can be found [here](./eksctl-config.yaml). | ||
| This field's value should be a string representing a base64-encoded EKS cluster config, an example of which can be found [EKS cluster config](./eksctl-config.yaml). |
Contributor
There was a problem hiding this comment.
Why this change? I think it read better before. If you really want to update it I recommend the following:
Suggested change
| This field's value should be a string representing a base64-encoded EKS cluster config, an example of which can be found [EKS cluster config](./eksctl-config.yaml). | |
| This field's value should be a string representing a base64-encoded EKS cluster config, an example of which can be found in this [EKS cluster config](./eksctl-config.yaml). |
Contributor
Author
There was a problem hiding this comment.
I really don't want to change, keep tell me lint issue, need to give a descriptive name
Contributor
Author
There was a problem hiding this comment.
after changed to what you suggested, got
yeazelm
approved these changes
Jun 5, 2025
gthao313
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
testsys: Update to 0.0.17
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.