Image Pull Secret template is broken

[alexsorkin]

  {{- if ((.Values.image_pull_secrets)) }}
  image_pull_secrets: 
    {{ .Values.image_pull_secrets }}
  {{- end }}

In helm template

[KCSesh]

Update: Hey @alexsorkin,

Updating my original comment:

I was able to reproduce - and it does appear to be a bug.

I see the issue is that our template files seem to be looking for image_pull_secrets but kubectl is looking for the camel case imagePullSecrets

I mistakenly used the camel case originally which was ignored.
However, my IAM role attached to my node had permissions to fetch the private container image, so it appeared to have worked.

But once I noticed this and tried to set the snake case, my helm upgrade fails:

➜  git:(master) ✗ helm upgrade --install brupop-operator brupop/bottlerocket-update-operator \
  -n brupop-bottlerocket-aws \
  -f custom-values.yaml
Error: UPGRADE FAILED: YAML parse error on bottlerocket-update-operator/templates/agent-daemonset.yaml: error converting YAML to JSON: yaml: line 82: did not find expected ',' or ']'

[KCSesh]

@alexsorkin So it seems if the IAM role has access, that should work. But of course that may not be ideal, and this is a bug.

Do you mind sharing your use case?

[ytsssun]

The PR is merged, we will plan a release soon. Meanwhile we will keep this ticket open until the fix is released.