feat(datastore): add batch metadata API and fix platform-specific errno#4871
Open
SURUJ404 wants to merge 2 commits into
Open
feat(datastore): add batch metadata API and fix platform-specific errno#4871SURUJ404 wants to merge 2 commits into
SURUJ404 wants to merge 2 commits into
Conversation
- Add set_metadata_batch() to DataStore trait with default implementation - Use the new batch API in migration-helpers datastore_helper - Replace raw os error 39 with io::ErrorKind::DirectoryNotEmpty
Author
|
These changes improve the datastore API's extensibility and code correctness. Adding set_metadata_batch to the DataStore trait provides a proper extension point — future backends (e.g. a database-backed datastore) can batch metadata writes into a single atomic operation, while existing filesystem and in-memory backends continue to work via the default implementation. This also cleans up the migration helper, removing the old "no batch API" workaround and keeping the looping logic in one canonical place. Replacing the hardcoded raw OS error 39 with io::ErrorKind::DirectoryNotEmpty eliminates a Linux-specific magic number that would silently misbehave on other platforms, making the codebase more portable and maintainable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.