Add wayland option in launch options#4532
Conversation
|
I was not aware the |
… fake_init Fixes test_run_program_substitutes_placeholders after adding program_wayland parameter to WineExecutor.__init__ in PR bottlesdevs#4532. Fredolx's PR adds the parameter but the mock's fake_init was not updated, causing TypeError: got an unexpected keyword argument 'program_wayland'. Both parameters are added to match the __init__ signature exactly.
Architectural Review & Second OpinionThis PR provides a highly necessary feature for per-executable runtime isolation. In complex winebottles, a global Wayland configuration might work flawlessly for 90% of the applications, while specific legacy executables or media players suffer from rendering glitches (e.g., zero-frame white screens or window lifecycle crashes). Myself had this problem on SmartersIPTV app time ago, sometimes worked, sometimes clics didnt work, sometimes white screen, most of times works but... enough for me and reason why i change my client towards open-tv/fredtv months ago. Allowing a granular, per-executable override to safely decouple specific processes back to XWayland/X11 without mutating the entire bottle layer is the correct architectural approach in my op. Clarification on the
|
fix(test): add missing program_wayland and sandbox_override to fake_init mock
Description
This PR adds a wayland option per-executable in the launch settings.
It is useful if the global wayland settings is useful for most executables in a bottle, except a few (white screen, crash)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.