refactor: HTTP backend abstraction#4
Open
edfloreshz wants to merge 1 commit into
Open
Conversation
| /// | ||
| /// Returning `None` is safe; the download will proceed without pre-flight | ||
| /// metadata and no [`crate::events::Event::Probed`] event will be emitted. | ||
| fn probe_head<'a>( |
There was a problem hiding this comment.
Shouldn't we rather abstract the HttpClient itself rather than abstracting specific requests?
What if we want to make other requests in the future, that means we would have to update this trait and and its implementor
Collaborator
Author
There was a problem hiding this comment.
How would you propose we do that? I could use some ideas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor to the download manager’s transport layer, making HTTP backend support pluggable and backend-agnostic. The
reqwestdependency is now optional and behind a feature flag, and a new trait-based abstraction allows for custom HTTP or non-HTTP backends. The context and configuration code are updated to use this new design.