Skip to content

Commit 46b3e1c

Browse files
chore: bump soroban-sdk to 27.0.0 and close out scanner noise (#87)
* chore: bump soroban-sdk to 27.0.0 and close out scanner noise - Bump soroban-sdk from 23.5.2 → 27.0.0 in workspace Cargo.toml - Bump Rust toolchain from 1.90.0 → 1.91.0 in rust-toolchain.toml (required by soroban-sdk 27.0.0) - Update build target reference in CLAUDE.md from wasm32-unknown-unknown to wasm32v1-none (required by Soroban environment ≥ SDK 22+, deploy scripts already used the correct target) - Update docs/scout-audit-report.md: - Mark soroban_version ENHANCEMENT as resolved - Record all ~44 storage_change_events ENHANCEMENT flags as no action (flagged functions already emit events; Scout cannot trace through dispatcher wrappers; ManagerChanged gap tracked in issue #3) All 197 events + 66 profile tests pass at soroban-sdk 27.0.0. Closes #77 * ci: use Rust 1.93 and stellar-cli 27 so the sdk-27 bump actually builds soroban-sdk 27.0.0 has MSRV 1.91.0, but the Stellar contract build tool blocklists Rust 1.91.0 exactly ("use a rust version other than 1.81, 1.82, 1.83 or 1.91.0"), so `make build` fails under the previously pinned 1.91.0. Pin 1.93.0 instead: it clears the SDK MSRV and is not on the blocklist. Verified with `stellar contract build` (cli 27.0.0), not just `cargo build` — the plain cargo path skips the blocklist check. Also bump the CI-pinned stellar-cli 23.1.3 -> 27.0.0 to match Protocol 27 (mainnet + testnet both run core 27.x), with its verified linux tarball SHA-256. Merge current testnet in to pick up the hardened CI action and the 1.3.0 contract changes, and regenerate Cargo.lock. Verified: stellar contract build OK for both contracts; events wasm 53,257 bytes (< 64 KB ceiling); cargo test 210 + 66 green; fmt clean. * ci(verify-build): trigger on toolchain + workspace manifest changes The build job only ran on contracts/** changes, so a Cargo.toml SDK bump or a rust-toolchain.toml / setup-rust-stellar change could merge without the build ever running — exactly the toolchain surface most likely to break the build. Add those paths so make build validates them. --------- Co-authored-by: Collins Ikechukwu <collinschristroa@gmail.com>
1 parent 57aa591 commit 46b3e1c

7 files changed

Lines changed: 183 additions & 121 deletions

File tree

.github/actions/setup-rust-stellar/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ runs:
1818

1919
- name: Install Stellar CLI
2020
run: |
21-
STELLAR_VERSION="23.1.3"
21+
STELLAR_VERSION="27.0.0"
2222
STELLAR_TAR="stellar-cli-${STELLAR_VERSION}-x86_64-unknown-linux-gnu.tar.gz"
23-
# Official SHA-256 from https://github.com/stellar/stellar-cli/releases/tag/v23.1.3
24-
STELLAR_SHA256="cca0a9e249176b15ac2d63a394b383c0699dd59cd52b67cd9593427f0d039d87"
23+
# Official SHA-256 from https://github.com/stellar/stellar-cli/releases/tag/v27.0.0
24+
STELLAR_SHA256="357bf712f6353c28cd33c794402a3c87231757a5b305e6ef1604365af4fdd556"
2525
2626
wget -q "https://github.com/stellar/stellar-cli/releases/download/v${STELLAR_VERSION}/${STELLAR_TAR}"
2727

.github/workflows/verify-build.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ on:
77
- testnet
88
paths:
99
- 'contracts/**'
10+
- 'Cargo.toml'
11+
- 'Cargo.lock'
12+
- 'rust-toolchain.toml'
13+
- '.github/actions/setup-rust-stellar/**'
1014
- '.github/workflows/verify-build.yml'
1115
# Use pull_request (not pull_request_target): the check must run the workflow
1216
# from the PR head so branch-filter changes take effect on the PR itself, and
@@ -19,6 +23,10 @@ on:
1923
- testnet
2024
paths:
2125
- 'contracts/**'
26+
- 'Cargo.toml'
27+
- 'Cargo.lock'
28+
- 'rust-toolchain.toml'
29+
- '.github/actions/setup-rust-stellar/**'
2230
- '.github/workflows/verify-build.yml'
2331
- '.github/workflows/rustfmt.yml'
2432
workflow_dispatch:

CLAUDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Source: <https://github.com/stellar/stellar-dev-skill>
2828

2929
```bash
3030
# Build
31-
cd contracts/events && cargo build --target wasm32-unknown-unknown --release
31+
cd contracts/events && cargo build --target wasm32v1-none --release
3232

3333
# Test (host target)
3434
cargo test -p boundless-events
@@ -46,7 +46,7 @@ Mainnet admin operations live behind the multi-sig defined in `docs/admin-custod
4646

4747
```bash
4848
cargo test -p boundless-events
49-
cargo build --release --target wasm32-unknown-unknown
49+
cargo build --release --target wasm32v1-none
5050
```
5151

5252
Update `BACKLOG.md` if your PR closes one of the entries there.

0 commit comments

Comments
 (0)