Add support for annotations in the Java networknt implementation harness#2624
Closed
VIDIT45AGARWAL wants to merge 6 commits into
Closed
Add support for annotations in the Java networknt implementation harness#2624VIDIT45AGARWAL wants to merge 6 commits into
VIDIT45AGARWAL wants to merge 6 commits into
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Member
|
We'll come back to this (harnesses) once something like #2642 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion on slack, added annotation support for networknt implementation without breaking the existing bowtie commands.
Now when the run command includes
"collect_annotations": true, the harness switches from simple validation to annotation collection, while without the flag behavior is identical to the current upstream harness.Working
collectAnnotations()method recursively walks the OutputUnit tree returned by networknt and extracts annotations as a nested map: instanceLocation → keyword → schemaLocation → valueTestResultrecord now has an optional annotations field, annotated with@JsonInclude(NON_EMPTY)so it is completely omitted from the JSON output when not in annotation modeTestrecord's valid field was changed frombooleantoJsonNodeto handle annotation test cases that may not have a valid fieldTesting
Output