feat(video): show timestamped comment markers on the V2 scrubber#1685
Draft
jmcbgaston wants to merge 2 commits into
Draft
feat(video): show timestamped comment markers on the V2 scrubber#1685jmcbgaston wants to merge 2 commits into
jmcbgaston wants to merge 2 commits into
Conversation
Renders avatar markers on the V2 video scrubber for every timestamped comment on the file, with a hover bubble (author, timecode, message, relative-time) and a click that pauses playback and emits a `timestamped_comment_click` viewer event for the host to act on (e.g. focus the matching comment in the activity sidebar). The viewer self-fetches its data via a new `TimestampedCommentsAPI` backed by `/2.0/file_activities` and self-listens for a host-emitted `timestamped_comment_changed` event so a sidebar-side create/edit/delete refreshes the markers without any host-side plumbing into BCP internals. Gated behind the existing `videoPlayerV2.enabled` feature.
Drops `enhanced_comment` entries with `status === 'resolved'` during parse so the marker overlay mirrors the activity sidebar's filtered view. Without this, resolving a comment in the sidebar left an orphan marker on the bar until the next page load; the row 9/10 reverse-emit + refetch loop already refreshes the data, this filter just lets the new snapshot drop the stale entry. Scopes the `/2.0/file_activities` request back to `enhanced_comment,task,versions`. Annotation markers (`enhanced_annotation` with `target.location.type === 'frame'`) need their own CRUD-parity mechanism and will land as a separate iteration. Adds a `handleTimestampedCommentClick` test asserting the marker click pauses playback and emits `timestamped_comment_click`.
jmcbgaston
changed the title
jmcbgaston
commented
Jun 23, 2026
| const cleaned = name.replace(/[[({<]+.*[\])}>]+/g, '').trim(); | ||
| if (!cleaned) return ''; | ||
| return cleaned.charAt(0).toUpperCase(); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
consider helper function
jmcbgaston
commented
Jun 23, 2026
| const diffMo = Math.round(diffDay / 30); | ||
| if (diffMo < 12) return `${diffMo}mo ago`; | ||
| return `${Math.round(diffMo / 12)}y ago`; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
consider util function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renders avatar markers on the V2 video scrubber for every timestamped comment on the file. Hovering a marker shows a bubble with author, timecode, message body, and relative time. Clicking a marker pauses playback and emits a
timestamped_comment_clickviewer event so the host app can route its sidebar to the matching comment.The viewer self-fetches its data via a new
TimestampedCommentsAPIbacked by/2.0/file_activities. Resolved comments are dropped from the parsed result so the bar mirrors the activity sidebar's filtered view. The viewer also self-listens for a host-emittedtimestamped_comment_changedevent and refetches when fired — letting any sidebar-side create / resolve / delete refresh the markers without the host reaching into BCP internals.Gated behind the existing
videoPlayerV2.enabledviewer option.Test plan
timestamped_comment_clickevent fires with the matching comment payload.videoPlayerV2.enabledoff, confirm no markers render and no extra/2.0/file_activitiesrequest is made.timestamped_comment_changedon the viewer after a sidebar-side create / resolve / delete. Confirm the bar refreshes within one refetch round-trip and a resolved comment's marker disappears.Semantic release type
feat- New feature