Skip to content

Fix deleteprofile - #816

Merged
HaGuesto merged 4 commits into
masterfrom
fix-deleteprofile
Mar 23, 2026
Merged

Fix deleteprofile#816
HaGuesto merged 4 commits into
masterfrom
fix-deleteprofile

Conversation

@pylipp

@pylipp pylipp commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

https://trello.com/c/XxhOyLc8

Testing

  1. log in as jane.doe@boxaid.co
  2. deactivate your own profile
  3. (check that Jane is blocked in Auth0, and/or the DB people/history tables)
  4. log in as dev_headofops@boxaid.org
  5. re-activate Jane Doe
  6. log out and back in as Jane

- now it sees user_id, too
- if updateAuth0UserFromDb fails, we don't end up with an inconsistent
  DB state
@pylipp
pylipp requested a review from HaGuesto February 6, 2026 18:07
<?php

db_transaction(function () {
$user_id = $_SESSION['user']['id'];

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy how unsafe that has been before

@HaGuesto

HaGuesto commented Mar 2, 2026

Copy link
Copy Markdown
Member

code Review passed

@HaGuesto HaGuesto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review passed

@HaGuesto
HaGuesto merged commit 64b1dfb into master Mar 23, 2026
6 checks passed
@HaGuesto
HaGuesto deleted the fix-deleteprofile branch March 23, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants