From 393ec97bbfa94dc2add8186127a7b7ca47cd4631 Mon Sep 17 00:00:00 2001 From: batphil Date: Wed, 31 Dec 2014 19:45:08 +0100 Subject: [PATCH 1/5] Update facebook.js adding support for data-width, default to 250 if it's not specified --- facebook.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/facebook.js b/facebook.js index 753ab8d..7dbb09c 100644 --- a/facebook.js +++ b/facebook.js @@ -229,6 +229,7 @@ module.directive ('facebookLogin', function () { module.directive('facebookLike', function ($location) { var template = '
Date: Wed, 31 Dec 2014 19:47:33 +0100 Subject: [PATCH 2/5] Update facebook.js because with actual code, when we set to false, sharing is even possible, so with new code it's seems works good, default to true --- facebook.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/facebook.js b/facebook.js index 7dbb09c..911fe07 100644 --- a/facebook.js +++ b/facebook.js @@ -234,7 +234,7 @@ module.directive('facebookLike', function ($location) { 'data-layout="{{layout || \'standard\'}}" ' + 'data-action="{{ action || \'like\'}}" ' + 'data-show-faces="{{!!showFaces}}" ' + - 'data-share="{{!!share}}"' + + 'data-share="{{share || \'true\'}}"' + 'data-action="{{action || \'like\'}}"' + 'data-send="false">
'; From d7da693dc1a4e200a23856b3df95e7fce0479889 Mon Sep 17 00:00:00 2001 From: batphil Date: Wed, 31 Dec 2014 19:56:02 +0100 Subject: [PATCH 3/5] other tag error :) --- facebook.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/facebook.js b/facebook.js index 911fe07..e6ea035 100644 --- a/facebook.js +++ b/facebook.js @@ -180,7 +180,7 @@ module.directive ('facebook', function ($location, facebook) { * during login default is basic_info. * * @example - * + * */ module.directive ('facebookLogin', function () { var template = From be3adb98c9e9e32c99f679f60cc1fc254f49a161 Mon Sep 17 00:00:00 2001 From: batphil Date: Wed, 31 Dec 2014 20:00:40 +0100 Subject: [PATCH 4/5] double --- facebook.js | 1 - 1 file changed, 1 deletion(-) diff --git a/facebook.js b/facebook.js index e6ea035..a453b08 100644 --- a/facebook.js +++ b/facebook.js @@ -232,7 +232,6 @@ module.directive('facebookLike', function ($location) { 'data-width="{{width || 250}}"' + 'data-colorscheme="{{colorScheme || \'light\'}}" ' + 'data-layout="{{layout || \'standard\'}}" ' + - 'data-action="{{ action || \'like\'}}" ' + 'data-show-faces="{{!!showFaces}}" ' + 'data-share="{{share || \'true\'}}"' + 'data-action="{{action || \'like\'}}"' + From 63793b93f2bd4779d9b9de7faa3807424eed4c60 Mon Sep 17 00:00:00 2001 From: batphil Date: Wed, 31 Dec 2014 20:12:25 +0100 Subject: [PATCH 5/5] adding documentation link --- facebook.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/facebook.js b/facebook.js index a453b08..44317a4 100644 --- a/facebook.js +++ b/facebook.js @@ -210,7 +210,7 @@ module.directive ('facebookLogin', function () { * @restrict E * * @description - * Shows facebook like/share/recommend button. + * Shows facebook like/share/recommend button, documentation here : https://developers.facebook.com/docs/plugins/like-button * * @param {string} href indicates the page that will be liked. if not provided current * absolute URL will be used.