Fix/712 714 bugs (CenterForOpenScience#429)

* fix(contributors): fixed contributors 2 bugs

* fix(styles): fixed styles for contributors

Author: nsemets

src/app/features/my-projects/mappers/my-resources.mapper.ts

@@ -11,10 +11,10 @@ export class MyResourcesMapper {
       isPublic: response.attributes.public,
       contributors:
         response.embeds?.bibliographic_contributors?.data?.map((contributor) => ({
-          familyName: contributor.embeds.users.data.attributes.family_name,
-          fullName: contributor.embeds.users.data.attributes.full_name,
-          givenName: contributor.embeds.users.data.attributes.given_name,
-          middleName: contributor.embeds.users.data.attributes.middle_name,
+          familyName: contributor.embeds.users.data?.attributes.family_name,
+          fullName: contributor.embeds.users.data?.attributes.full_name,
+          givenName: contributor.embeds.users.data?.attributes.given_name,
+          middleName: contributor.embeds.users.data?.attributes.middle_name,
         })) ?? [],
     };
   }

src/app/shared/components/contributors/add-contributor-dialog/add-contributor-dialog.component.html

@@ -11,8 +11,8 @@
       } @else {
         @for (item of users(); track $index) {
           <div class="border-divider flex pb-3">
-            <p-checkbox variant="filled" [value]="item" [inputId]="item.id" [(ngModel)]="selectedUsers"></p-checkbox>
-            <label class="label ml-2" [for]="item.id">{{ item.fullName }}</label>
+            <p-checkbox variant="filled" [value]="item" [(ngModel)]="selectedUsers"></p-checkbox>
+            <a class="ml-2 font-bold" [href]="item.id" target="_blank">{{ item.fullName }}</a>
           </div>
         }
 

src/app/shared/components/contributors/add-contributor-dialog/add-contributor-dialog.component.scss

@@ -1,11 +1,5 @@
 @use "styles/mixins" as mix;
 
-.label {
-  color: var(--dark-blue-1);
-  margin: 0;
-  cursor: pointer;
-}
-
 .border-divider {
   border-bottom: 1px solid var(--grey-2);
 }

src/app/shared/components/cookie-consent/cookie-consent.component.html

@@ -3,11 +3,7 @@
     <div class="flex flex-column gap-2">
       <span>{{ message.detail }}</span>
       <div class="flex justify-content-end">
-        <p-button
-          type="button"
-          label="{{ 'toast.cookie-consent.accept' | translate }}"
-          (click)="acceptCookies()"
-        ></p-button>
+        <p-button [label]="'toast.cookie-consent.accept' | translate" (onClick)="acceptCookies()"></p-button>
       </div>
     </div>
   </ng-template>

src/app/shared/mappers/contributors/contributors.mapper.ts

@@ -36,8 +36,8 @@ export class ContributorsMapper {
           ({
             id: user.id,
             fullName: user.attributes.full_name,
-            isBibliographic: false,
-            permission: ContributorPermission.Read,
+            isBibliographic: true,
+            permission: ContributorPermission.Write,
           }) as ContributorAddModel
       ),
       totalCount: response.meta.total,