Skip to content

Commit 561b59d

Browse files
brabojclaude
andcommitted
docs: add review section and review-before-merge rule
Adds section 2.2 (Review) that was lost during the restructure, and adds an explicit review-before-merge rule to the git conventions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 1f3afab commit 561b59d

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

CLAUDE.md

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,17 @@ Extends `docs/solid-ai-templates/base/git.md` with project-specific rules:
6161
feature branch
6262
- One commit per logical change
6363
- PR title: concise, under 70 characters
64+
- Before merging, review the diff — follow `base/review.md` priority
65+
order and check CI passes
6466
- Delete feature branch after merge (local and remote)
6567

66-
### 2.2 Content
68+
### 2.2 Review
69+
70+
Follow `docs/solid-ai-templates/base/review.md` priority order:
71+
security → correctness → clarity → conventions. Apply
72+
`docs/solid-ai-templates/base/quality.md` as the standard.
73+
74+
### 2.3 Content
6775

6876
#### Chapter structure
6977

@@ -91,7 +99,7 @@ Every chapter follows this structure:
9199
- Vary the correct answer positions — never all the same letter
92100
- Answers section at the bottom: `1. C — explanation`
93101

94-
### 2.3 Cross-references
102+
### 2.4 Cross-references
95103

96104
- Reference other chapters by file: `[Building Blocks](02-building-blocks.md)`
97105
- Reference sections within a chapter by heading anchor: `[Tag Object](#tag-object-labels)`
@@ -102,7 +110,7 @@ Every chapter follows this structure:
102110
- Recipe pages live in `chapters/recipes/` but their URLs are
103111
`/playbook/...` — link to them as `playbook/X.md`, not `recipes/X.md`
104112

105-
### 2.4 Images
113+
### 2.5 Images
106114

107115
- Source files: `assets/drawio/` (`.drawio` format)
108116
- Exported PNGs: `assets/images/`
@@ -111,7 +119,7 @@ Every chapter follows this structure:
111119
- ASCII diagrams in markdown serve as fallback and source of truth
112120

113121

114-
### 2.5 Figures
122+
### 2.6 Figures
115123

116124
Every figure follows these rules. Applies to draw.io XML, PlantUML, and SVG.
117125

0 commit comments

Comments
 (0)