Skip to content

fix: implement route-level authentication guards for auth-gated endpo… #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samriddhighosh wants to merge 1 commit into
base: main
Choose a base branch
from
+8,988 −17
Open

fix: implement route-level authentication guards for auth-gated endpo… #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions docs/QA_CHECKLIST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ Rules of thumb:

## Environments

| Env | URL | Auth |
|---|---|---|
| Local preview | `http://localhost:8080` | preview-mode bypass, you are signed in as `Preview User` |
| Staging | `https://staging.brain-bbqs.org` | `staging-fake-login` edge function (admin/member fixtures) |
| Prod | `https://brain-bbqs.org` | Globus OAuth — **DO NOT submit test data here** |
| Env | URL | Auth |
| ------------- | -------------------------------- | ---------------------------------------------------------- |
| Local preview | `http://localhost:8080` | preview-mode bypass, you are signed in as `Preview User` |
| Staging | `https://staging.brain-bbqs.org` | `staging-fake-login` edge function (admin/member fixtures) |
| Prod | `https://brain-bbqs.org` | Globus OAuth — **DO NOT submit test data here** |

Run all manual + automated QA against **staging** unless told otherwise.

Expand Down Expand Up @@ -244,15 +244,15 @@ Playwright: `§12 working-groups`.

## §13 Calendar (`/calendar`) — auth required

- [ ] Anon hitting `/calendar` is redirected to `/auth`
- [x] Anon hitting `/calendar` is redirected to `/auth`
- [ ] Member sees events on month/week views
- [ ] Event click opens detail

Playwright: `§13 calendar` (anon-redirect only).

## §14 Roadmap (`/roadmap`) — auth required

- [ ] Anon hitting `/roadmap` is redirected to `/auth`
- [x] Anon hitting `/roadmap` is redirected to `/auth`
- [ ] Authed user sees milestones from `github-roadmap` edge function
- [ ] Each milestone card links to its GitHub issue in a new tab

Expand All @@ -262,7 +262,7 @@ Playwright: `§14 roadmap` (anon-redirect only).

- [ ] Landing page renders agenda, speakers, register CTA
- [ ] Register CTA opens correct form / new tab
- [ ] Travel page is auth-gated (anon → `/auth`)
- [x] Travel page is auth-gated (anon → `/auth`)
- [ ] Hotel map (`HotelLocationMap`) renders all hotel pins
- [ ] Date warnings (see memory: `mit-workshop-travel`) render correctly

Expand All @@ -277,7 +277,7 @@ Playwright: `§16 sfn`.

## §17 Profile (`/profile`) — auth required

- [ ] Anon → `/auth`
- [x] Anon → `/auth`
- [ ] Member sees own profile only
- [ ] Linked-email member can edit their own grants; not others
- [ ] Onboarding modal shows for first-time user; dismiss persists in localStorage
Expand All @@ -286,7 +286,7 @@ Playwright: `§17 profile` (anon-redirect only).

## §18 Admin Console (`/admin`) — admin only

- [ ] Anon → `/auth`
- [x] Anon → `/auth`
- [ ] Member → redirected away / 403
- [ ] Admin sees: Access Requests tab, Users tab, System Alerts banner
- [ ] Approving an access request mutates `user_roles`
Expand Down Expand Up @@ -361,4 +361,4 @@ Link the issue back into this file as `[x] (bug #<n>)` so we can track coverage.
- Every `test.todo` in `e2e/qa-checklist.spec.ts` is either implemented or
replaced with a `test.fail(...)` that references a tracked bug.
- `npx playwright test e2e/qa-checklist.spec.ts` passes on chromium **and** mobile.
- `docs/QA_PLAN.md` §2 is updated to flip the corresponding 🔴 → ✅ rows.
- `docs/QA_PLAN.md` §2 is updated to flip the corresponding 🔴 → ✅ rows.
Loading