use const int instead

braindigitalis · braindigitalis · commit 79dc59ec1565 · 2025-03-19T18:09:22.000Z
diff --git a/src/dpp/sslconnection.cpp b/src/dpp/sslconnection.cpp
@@ -107,7 +107,7 @@ bool close_socket(dpp::socket sfd)
 
 bool set_nonblocking(dpp::socket sockfd, bool non_blocking)
 {
-	static int enable{1};
+	const int enable{1};
 #ifdef _WIN32
 	u_long mode = non_blocking ? 1 : 0;
 	int result = ioctlsocket(sockfd, FIONBIO, &mode);
@@ -125,7 +125,7 @@ bool set_nonblocking(dpp::socket sockfd, bool non_blocking)
 		return false;
 	}
 #endif
-	setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, reinterpret_cast<char*>(&enable), sizeof(int));
+	setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, reinterpret_cast<const char*>(&enable), sizeof(int));
 	return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ bool close_socket(dpp::socket sfd)`
`107`	`107`
`108`	`108`	`bool set_nonblocking(dpp::socket sockfd, bool non_blocking)`
`109`	`109`	`{`
`110`		`- static int enable{1};`
	`110`	`+ const int enable{1};`
`111`	`111`	`#ifdef _WIN32`
`112`	`112`	`u_long mode = non_blocking ? 1 : 0;`
`113`	`113`	`int result = ioctlsocket(sockfd, FIONBIO, &mode);`
`@@ -125,7 +125,7 @@ bool set_nonblocking(dpp::socket sockfd, bool non_blocking)`
`125`	`125`	`return false;`
`126`	`126`	`}`
`127`	`127`	`#endif`
`128`		`- setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, reinterpret_cast<char*>(&enable), sizeof(int));`
	`128`	`+ setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, reinterpret_cast<const char*>(&enable), sizeof(int));`
`129`	`129`	`return true;`
`130`	`130`	`}`
`131`	`131`