Add C++ modules support and update nlohmann::json#1528
Closed
mikomikotaishi wants to merge 1 commit intobrainboxdotcc:masterfrom
Closed
Add C++ modules support and update nlohmann::json#1528mikomikotaishi wants to merge 1 commit intobrainboxdotcc:masterfrom
mikomikotaishi wants to merge 1 commit intobrainboxdotcc:masterfrom
Conversation
Contributor
|
Thank you for your contribution, but PRs must be raised against the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for C++20 modules.
In order to accomplish this, some constants were changed to using external linkage. I have also updated nlohmann/json to version 3.12.0, as the older version declares some symbols as internal.
Code change checklist