Skip to content

Add C++ modules support and update nlohmann::json#1528

Closed
mikomikotaishi wants to merge 1 commit intobrainboxdotcc:masterfrom
mikomikotaishi:master
Closed

Add C++ modules support and update nlohmann::json#1528
mikomikotaishi wants to merge 1 commit intobrainboxdotcc:masterfrom
mikomikotaishi:master

Conversation

@mikomikotaishi
Copy link
Copy Markdown
Contributor

This pull request adds support for C++20 modules.

In order to accomplish this, some constants were changed to using external linkage. I have also updated nlohmann/json to version 3.12.0, as the older version declares some symbols as internal.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 27, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions Bot closed this Dec 27, 2025
@github-actions github-actions Bot added documentation Improvements or additions to documentation build Issue or Pull Request related to the build process code Improvements or additions to code. labels Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issue or Pull Request related to the build process code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants