Skip to content

Added DPP_EXPORT to bignum.h bn_deleter::operator()#1541

Closed
andrevanduin wants to merge 1 commit intobrainboxdotcc:masterfrom
andrevanduin:master
Closed

Added DPP_EXPORT to bignum.h bn_deleter::operator()#1541
andrevanduin wants to merge 1 commit intobrainboxdotcc:masterfrom
andrevanduin:master

Conversation

@andrevanduin
Copy link
Copy Markdown
Contributor

Added a missing DPP_EXPORT on bn_deleter::operator() since not exporting this symbol causes Windows build to fail since it does not export symbols by default.

Without the change during linking on Windows you get:
image

With the small change it works as expected.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 2, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2026

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions Bot closed this Jan 2, 2026
@github-actions github-actions Bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants