Skip to content

chore: Update nlohmann/json to 3.12.0#1596

Merged
braindigitalis merged 1 commit into
brainboxdotcc:devfrom
mikomikotaishi:update-nlohmann-json
Jun 29, 2026
Merged

chore: Update nlohmann/json to 3.12.0#1596
braindigitalis merged 1 commit into
brainboxdotcc:devfrom
mikomikotaishi:update-nlohmann-json

Conversation

@mikomikotaishi

Copy link
Copy Markdown
Contributor

This PR updates nlohmann/json to 3.12.0. While I previously intended to merge such an update in #1530, many pointed out this was best merged as a separate PR to reduce scope.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify

netlify Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 9de4ae8
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/6a42db25f5bc570008f79d7a
😎 Deploy Preview https://deploy-preview-1596--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the code Improvements or additions to code. label Jun 29, 2026
@braindigitalis

Copy link
Copy Markdown
Contributor

how come the sha256sum doesn't match 3.12.0 and the diff is completely different, is this the develop branch of nlohmann?

@mikomikotaishi

Copy link
Copy Markdown
Contributor Author

Ah, I did directly copy it from the development branch. My apologies, I'll change it back to the release version.

@braindigitalis braindigitalis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ship it!

@braindigitalis braindigitalis merged commit e5d158d into brainboxdotcc:dev Jun 29, 2026
38 checks passed
@mikomikotaishi mikomikotaishi deleted the update-nlohmann-json branch June 29, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants