fix MID$ and improve demo massively

Author: braindigitalis

build-usb.php

@@ -25,7 +25,6 @@
 }
 
 function run(string $cmd, array $env = []): void {
-    echo ">> RUN: $cmd\n";
     $proc = proc_open($cmd, [1=>['pipe','w'], 2=>['pipe','w']], $pipes, null, $env + $_ENV);
     if (!is_resource($proc)) {
         throw new RuntimeException("failed to start: $cmd");
@@ -56,6 +55,8 @@ function align_up(int $x, int $a): int {
 ensure_file(LIMINE_BIN);
 ensure_file(LIMINE_CONF);
 
+echo ">> Compressing root.iso.gz\n";
+
 $root_gz = BUILD_DIR . '/root.iso.gz';
 run(sprintf("gzip -9 -n -c %s > %s", escapeshellarg(RR_ISO), escapeshellarg($root_gz)));
 
@@ -75,16 +76,24 @@ function align_up(int $x, int $a): int {
     unlink(OUT_IMG);
 }
 
+echo ">> Truncating " . OUT_IMG . "\n";
+
 run(sprintf("truncate -s %d %s", $img_bytes, escapeshellarg(OUT_IMG)));
 
+echo ">> Partitioning " . OUT_IMG . "\n";
+
 run(sprintf("sgdisk -o -a 1 -n 1:34:2047 -t 1:ef02 -n 2:%d:0 -t 2:ef00 %s", $start_lba, escapeshellarg(OUT_IMG)));
 run(sprintf("sgdisk --hybrid 2:EE %s", escapeshellarg(OUT_IMG)));
 run(sprintf("printf 'a\n1\nw\n' | fdisk %s", escapeshellarg(OUT_IMG)));
 
 $env = ['MTOOLS_SKIP_CHECK' => '1'];
 
+echo ">> Formatting " . OUT_IMG . "\n";
+
 run(sprintf("mformat -i %s@@%d -F -v %s ::", escapeshellarg(OUT_IMG), $offset_bytes, escapeshellarg(VOL_LABEL)), $env);
 
+echo ">> Copying files to " . OUT_IMG . "\n";
+
 $img_spec = escapeshellarg(OUT_IMG . '@@' . (string)$offset_bytes);
 
 run("mmd -i $img_spec ::/EFI", $env);
@@ -97,9 +106,13 @@ function align_up(int $x, int $a): int {
 run(sprintf("mcopy -i %s %s ::/root.iso.gz", $img_spec, escapeshellarg($root_gz)), $env);
 run(sprintf("mcopy -i %s %s ::/limine.conf", $img_spec, escapeshellarg(LIMINE_CONF)), $env);
 
+echo ">> Installing bootloader to " . OUT_IMG . "\n";
+
 // Install BIOS bootloader
 run(sprintf("%s bios-install %s 1", escapeshellarg(LIMINE_BIN), escapeshellarg(OUT_IMG)));
 
+echo ">> Fixup\n";
+
 $fp = fopen(OUT_IMG, 'r+b');
 if ($fp === false) {
     throw new RuntimeException("failed to open image for MBR boot flag update");

include/pci.h

@@ -6,26 +6,47 @@
 #pragma once
 #include <kernel.h>
 
+/**
+ * @brief PCI subclass descriptor
+ *
+ * Represents a PCI subclass entry, including the subclass ID,
+ * programming interface, and a human-readable description.
+ */
 typedef struct {
-       uint8_t id;
-       uint8_t subclass;
-       uint8_t progif;
-       const char* description;
+	uint8_t id;               /**< Subclass ID */
+	uint8_t subclass;         /**< Subclass code */
+	uint8_t progif;           /**< Programming interface */
+	const char* description;  /**< Human-readable description */
 } pci_subclass;
 
+/**
+ * @brief Encoded PCI device address for configuration access
+ *
+ * This union represents the 32-bit value written to the PCI
+ * configuration address port (0xCF8). It encodes bus, device,
+ * function, and register offset fields.
+ *
+ * The layout matches the standard PCI configuration mechanism #1.
+ */
 typedef union pci_dev {
-    uint32_t bits;
-    struct {
-        uint32_t always_zero    : 2;
-        uint32_t field_num      : 6;
-        uint32_t function_num   : 3;
-        uint32_t device_num     : 5;
-        uint32_t bus_num        : 8;
-        uint32_t reserved       : 7;
-        uint32_t enable         : 1;
-    };
+	uint32_t bits;            /**< Raw 32-bit encoded value */
+	struct {
+		uint32_t always_zero    : 2; /**< Must be zero */
+		uint32_t field_num      : 6; /**< Register offset (DWORD aligned) */
+		uint32_t function_num   : 3; /**< Function number */
+		uint32_t device_num     : 5; /**< Device number */
+		uint32_t bus_num        : 8; /**< Bus number */
+		uint32_t reserved       : 7; /**< Reserved, must be zero */
+		uint32_t enable         : 1; /**< Enable bit (must be set to 1) */
+	};
 } pci_dev_t;
 
+/**
+ * @brief Zero-initialised PCI device descriptor
+ *
+ * Used as a default or sentinel value when no valid PCI device
+ * is selected.
+ */
 extern pci_dev_t dev_zero;
 
 #define PCI_CONFIG_ADDRESS       0xCF8

os/images/cat.gif

@@ -6,6 +6,7 @@ CX# = GRAPHICS_WIDTH / 2
 CY# = GRAPHICS_HEIGHT / 2
 SCALE# = 250
 DIST# = 3
+SPEED# = 0.03
 
 PAGE OFF
 SPRITELOAD s1, "/images/s1.png"
@@ -121,55 +122,39 @@ DEF FNloop(q)
   NEXT
   RECTANGLE min_x# - 16, min_y# - 16, max_x# + 16, max_y# + 16
 
-  ANGLE# = ANGLE# + 0.07
+  ANGLE# = ANGLE# + SPEED#
   SY# = SIN(ANGLE#)
   CYR# = COS(ANGLE#)
-  SX# = SIN(ANGLE# * 0.7)
-  CXR# = COS(ANGLE# * 0.7)
+  SX# = SIN(ANGLE# * SPEED# * 3)
+  CXR# = COS(ANGLE# * SPEED# * 3)
 
   FOR I = 0 TO 7
-    X# = VX#(I)
-    Y# = VY#(I)
-    Z# = VZ#(I)
-
-    X1# = X# * CYR# - Z# * SY#
-    Z1# = X# * SY# + Z# * CYR#
-
-    Y1# = Y# * CXR# - Z1# * SX#
-    Z2# = Y# * SX# + Z1# * CXR#
-
+    X1# = VX#(I) * CYR# - VZ#(I) * SY#
+    Z1# = VX#(I) * SY# + VZ#(I) * CYR#
+    Y1# = VY#(I) * CXR# - Z1# * SX#
+    Z2# = VY#(I) * SX# + Z1# * CXR#
     Xr#(I) = X1#
     Yr#(I) = Y1#
     Zr#(I) = Z2#
-
     DEN# = Z2# + DIST# + 0.00000000001
-
     PX#(I) = CX# + (X1# * SCALE# / DEN#)
     PY#(I) = CY# + (Y1# * SCALE# / DEN#)
-
   NEXT
 
   FOR f = 0 TO 5
-    a = F(f * 4 + 0)
-    b = F(f * 4 + 1)
-    c = F(f * 4 + 2)
-    d = F(f * 4 + 3)
-    DEPTH#(f) = (Zr#(a) + Zr#(b) + Zr#(c) + Zr#(d)) / 4
+    DEPTH#(f) = (Zr#(F(f * 4 + 0)) + Zr#(F(f * 4 + 1)) + Zr#(F(f * 4 + 2)) + Zr#(F(f * 4 + 3))) / 4
     IDX(f) = f
   NEXT
 
   ARRSORTBY IDX, DEPTH#, TRUE
 
   FOR k = 0 TO 5
     f = IDX(k)
-
     a = F(f * 4 + 0)
     b = F(f * 4 + 1)
     c = F(f * 4 + 2)
     d = F(f * 4 + 3)
-
     PLOTQUAD s1, PX#(a),PY#(a), PX#(b),PY#(b), PX#(c),PY#(c), PX#(d),PY#(d)
-
   NEXT
 
   frame_len = TICKS - start