MSI is only unsafe on E1000_82541PI due to hardware bug errata

braindigitalis · braindigitalis · commit d967c1ad06d7 · 2025-10-29T04:13:43.000Z
diff --git a/modules/e1000/e1000.c b/modules/e1000/e1000.c
@@ -323,7 +323,7 @@ bool e1000_start(pci_dev_t *pci_device) {
 		e1000_write_command(0x5200 + i * 4, 0);
 	}
 
-	if (e1000_device_id == E1000_82540EM) {
+	if (e1000_device_id != E1000_82541PI) {
 		/* Attempting MSI setup is safe here */
 		pci_setup_interrupt("e1000", *pci_device, logical_cpu_id(), e1000_handler, NULL);
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ bool e1000_start(pci_dev_t *pci_device) {`
`323`	`323`	`e1000_write_command(0x5200 + i * 4, 0);`
`324`	`324`	`}`
`325`	`325`
`326`		`- if (e1000_device_id == E1000_82540EM) {`
	`326`	`+ if (e1000_device_id != E1000_82541PI) {`
`327`	`327`	`/* Attempting MSI setup is safe here */`
`328`	`328`	`pci_setup_interrupt("e1000", *pci_device, logical_cpu_id(), e1000_handler, NULL);`
`329`	`329`	`} else {`