Skip to content

Commit ea8792c

Browse files
author
Florian Eckerstorfer
committed
Merge pull request #376 from althaus/fix-formtypes
Upgrade to Symfony 2.6 compatible form types (#374)
2 parents f166677 + d50c8bc commit ea8792c

5 files changed

Lines changed: 15 additions & 15 deletions

File tree

Form/Type/BootstrapCollectionType.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
use Symfony\Component\Form\FormView;
1111
use Symfony\Component\Form\FormInterface;
1212
use Symfony\Component\OptionsResolver\Options;
13-
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
13+
use Symfony\Component\OptionsResolver\OptionsResolver;
1414

1515
/**
1616
* BootstrapCollectionType
@@ -54,7 +54,7 @@ public function buildView(FormView $view, FormInterface $form, array $options)
5454
/**
5555
* {@inheritDoc}
5656
*/
57-
public function setDefaultOptions(OptionsResolverInterface $resolver)
57+
public function configureOptions(OptionsResolver $resolver)
5858
{
5959
$optionsNormalizer = function (Options $options, $value) {
6060
// @codeCoverageIgnoreStart
@@ -77,7 +77,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)
7777
'options' => array(),
7878
));
7979

80-
$resolver->setNormalizers(array('options' => $optionsNormalizer));
80+
$resolver->setNormalizer('options', $optionsNormalizer);
8181
}
8282

8383
/**

Form/Type/FormActionsType.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
use Symfony\Component\Form\FormBuilderInterface;
99
use Symfony\Component\Form\FormInterface;
1010
use Symfony\Component\Form\FormView;
11-
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
11+
use Symfony\Component\OptionsResolver\OptionsResolver;
1212

1313
/**
1414
* Class FormActionsType
@@ -80,7 +80,7 @@ protected function validateButton(FormInterface $field)
8080
/**
8181
* {@inheritdoc}
8282
*/
83-
public function setDefaultOptions(OptionsResolverInterface $resolver)
83+
public function configureOptions(OptionsResolver $resolver)
8484
{
8585
$resolver->setDefaults(array(
8686
'buttons' => array(),

Form/Type/FormStaticControlType.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
namespace Braincrafted\Bundle\BootstrapBundle\Form\Type;
77

88
use Symfony\Component\Form\AbstractType;
9-
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
9+
use Symfony\Component\OptionsResolver\OptionsResolver;
1010

1111
/**
1212
* FormStaticControlType
@@ -23,7 +23,7 @@ class FormStaticControlType extends AbstractType
2323
/**
2424
* {@inheritdoc}
2525
*/
26-
public function setDefaultOptions(OptionsResolverInterface $resolver)
26+
public function configureOptions(OptionsResolver $resolver)
2727
{
2828
$resolver->setDefaults(array(
2929
//'mapped' => false,

Tests/Form/Type/BootstrapCollectionTypeTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,15 @@ public function testBuildView()
5050
}
5151

5252
/**
53-
* @covers Braincrafted\Bundle\BootstrapBundle\Form\Type\BootstrapCollectionType::setDefaultOptions()
53+
* @covers Braincrafted\Bundle\BootstrapBundle\Form\Type\BootstrapCollectionType::configureOptions()
5454
*/
55-
public function testSetDefaultOptions()
55+
public function testConfigureOptions()
5656
{
57-
$resolver = m::mock('Symfony\Component\OptionsResolver\OptionsResolverInterface');
57+
$resolver = m::mock('Symfony\Component\OptionsResolver\OptionsResolver');
5858
$resolver->shouldReceive('setDefaults');
59-
$resolver->shouldReceive('setNormalizers');
59+
$resolver->shouldReceive('setNormalizer');
6060

61-
$this->type->setDefaultOptions($resolver);
61+
$this->type->configureOptions($resolver);
6262
}
6363

6464
/**

Tests/Form/Type/FormActionsTypeTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public function testBuildViewWithBadField()
9090
$this->type->buildView($view, $form, $options);
9191
}
9292

93-
public function testSetDefaultOptions()
93+
public function testConfigureOptions()
9494
{
9595

9696
$defaults = array(
@@ -99,10 +99,10 @@ public function testSetDefaultOptions()
9999
'mapped' => false,
100100
);
101101

102-
$resolver = m::mock('Symfony\Component\OptionsResolver\OptionsResolverInterface');
102+
$resolver = m::mock('Symfony\Component\OptionsResolver\OptionsResolver');
103103
$resolver->shouldReceive('setDefaults')->with($defaults)->once();
104104

105-
$this->type->setDefaultOptions($resolver);
105+
$this->type->configureOptions($resolver);
106106
}
107107

108108
public function testGetName()

0 commit comments

Comments
 (0)