Skip to content

Commit f166677

Browse files
author
Florian Eckerstorfer
committed
Merge pull request #375 from assimtech/symfony26
#374 Upgrade to symfony 2.6 compatible form extensions
2 parents 2acc745 + d7d66dc commit f166677

4 files changed

Lines changed: 17 additions & 14 deletions

File tree

Form/Extension/ButtonTypeExtension.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Braincrafted\Bundle\BootstrapBundle\Form\Extension;
44

55
use Symfony\Component\Form\AbstractTypeExtension;
6-
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
6+
use Symfony\Component\OptionsResolver\OptionsResolver;
77
use Symfony\Component\Form\FormView;
88
use Symfony\Component\Form\FormInterface;
99

@@ -29,11 +29,13 @@ public function buildView(FormView $view, FormInterface $form, array $options)
2929
}
3030

3131
/**
32+
* Add the button_class option
33+
* Add the as_link option
3234
* {@inheritdoc}
3335
*/
34-
public function setDefaultOptions(OptionsResolverInterface $resolver)
36+
public function configureOptions(OptionsResolver $resolver)
3537
{
36-
$resolver->setOptional(array('button_class', 'as_link'));
38+
$resolver->setDefined(array('button_class', 'as_link'));
3739
}
3840

3941
/**

Form/Extension/StaticControlExtension.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Braincrafted\Bundle\BootstrapBundle\Form\Extension;
44

55
use Symfony\Component\Form\AbstractTypeExtension;
6-
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
6+
use Symfony\Component\OptionsResolver\OptionsResolver;
77
use Symfony\Component\Form\FormView;
88
use Symfony\Component\Form\FormInterface;
99
use Symfony\Component\Form\FormBuilderInterface;
@@ -29,11 +29,12 @@ public function buildView(FormView $view, FormInterface $form, array $options)
2929
}
3030

3131
/**
32+
* Add the static_control option
3233
* {@inheritdoc}
3334
*/
34-
public function setDefaultOptions(OptionsResolverInterface $resolver)
35+
public function configureOptions(OptionsResolver $resolver)
3536
{
36-
$resolver->setOptional(array('static_control'));
37+
$resolver->setDefined(array('static_control'));
3738
}
3839

3940
/**

Tests/Form/Extension/InputGroupButtonExtensionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function testBuildView()
6565
}
6666

6767
/**
68-
* @covers Braincrafted\Bundle\BootstrapBundle\Form\Extension\InputGroupBtnExtension::buildForm()
68+
* @covers Braincrafted\Bundle\BootstrapBundle\Form\Extension\InputGroupButtonExtension::buildForm()
6969
* @dataProvider provideForform
7070
*/
7171
public function testBuildForm($options)
@@ -121,7 +121,7 @@ public function provideForForm()
121121
}
122122

123123
/**
124-
* @covers Braincrafted\Bundle\BootstrapBundle\Form\Extension\InputGroupBtnExtension::getExtendedType()
124+
* @covers Braincrafted\Bundle\BootstrapBundle\Form\Extension\InputGroupButtonExtension::getExtendedType()
125125
*/
126126
public function testGetExtendedType()
127127
{

composer.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
],
1414
"require": {
1515
"php": ">=5.3.3",
16-
"symfony/framework-bundle": "~2.3",
17-
"symfony/twig-bundle": "~2.3",
18-
"symfony/form": "~2.3",
19-
"symfony/console": "~2.3",
20-
"symfony/finder": "~2.3"
16+
"symfony/framework-bundle": "~2.6",
17+
"symfony/twig-bundle": "~2.6",
18+
"symfony/form": "~2.6",
19+
"symfony/console": "~2.6",
20+
"symfony/finder": "~2.6"
2121
},
2222
"require-dev": {
23-
"symfony/assetic-bundle": "~2.3",
23+
"symfony/assetic-bundle": "~2.6",
2424
"knplabs/knp-menu": "~2.0@alpha",
2525
"knplabs/knp-menu-bundle": "~2.0@alpha",
2626
"knplabs/knp-paginator-bundle": "dev-master",

0 commit comments

Comments
 (0)