Set correct number for the rc metadata#32
Merged
brainelectronics merged 1 commit intomainfrom Apr 11, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 11 11
Branches 1 1
=========================================
Hits 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brainelectronics
force-pushed
the
feature/real-rc-number
branch
from
87845e1 to
746d196
Compare
brainelectronics
force-pushed
the
feature/real-rc-number
branch
from
746d196 to
1962d8b
Compare
Owner
Author
brainelectronics
left a comment
brainelectronics
left a comment
There was a problem hiding this comment.
This is a game changer!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change creates the correct release candidate number based on the action run of a pull request workflow run
test-releaseinstead of the total number of this workflow run. By this fix, the-rcXmetadata starts at1and is incremented with every push, no matter if the push is a force push or a classic new commit on top in a ongoing pull request.