Skip to content

Commit 79a6aed

Browse files
authored
fix: use npm install for rql-editor build (no package-lock.json) (#41)
* fix: resolve npm workspace conflict in release workflow Replace `working-directory: apps/reasondb-client` + `npm ci` with `npm ci --prefix apps/reasondb-client` run from the repo root. npm auto-detects --workspace when CWD is inside a workspace member dir (apps/reasondb-client), which conflicts with --no-workspaces set by the root .npmrc (workspaces=false). Running from the repo root keeps CWD at the workspace root (not a member), so no --workspace is auto-set, the conflict disappears, and --prefix still installs node_modules into the correct apps/reasondb-client directory. * fix: remove workspaces=false from root .npmrc to unblock tauri action The tauri-apps/tauri-action internally runs npm commands (npm run tauri build) from apps/reasondb-client. npm v9/v10 auto-detects workspace membership and sets --workspace=reasondb-client, which conflicts with --no-workspaces set by workspaces=false in root .npmrc. Since this is a third-party action we cannot control, the only fix is to remove the root .npmrc setting that causes --no-workspaces globally. To keep the explicit npm ci install isolated from workspace detection, the Install step now cd's into $RUNNER_TEMP (outside the monorepo path) before running npm ci --prefix, so npm never traverses into the monorepo's .npmrc and workspace auto-detection never fires for that step. * fix: build @reasondb/rql-editor before Tauri build in release workflow The package-lock.json resolves @reasondb/rql-editor as a local symlink to packages/rql-editor, but that package must be built first so its dist/ output (and type declarations) exist when tsc compiles the app. Run npm ci + npm run build for packages/rql-editor (from RUNNER_TEMP to avoid workspace detection) before the main npm ci step. * fix: use npm install instead of npm ci for rql-editor (no package-lock.json)
1 parent 0b0c312 commit 79a6aed

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ jobs:
143143
shell: bash
144144
run: |
145145
cd "$RUNNER_TEMP"
146-
npm ci --prefix "$GITHUB_WORKSPACE/packages/rql-editor"
146+
npm install --prefix "$GITHUB_WORKSPACE/packages/rql-editor" --ignore-scripts
147147
npm run build --prefix "$GITHUB_WORKSPACE/packages/rql-editor"
148148
149149
- name: Install frontend dependencies

0 commit comments

Comments
 (0)