removed gain from BrainFlowInputParams, format

Author: neuropawn-admin

src/board_controller/neuropawn/inc/knight_base.h

@@ -18,7 +18,6 @@ class KnightBase : public Board
     Serial *serial;
 
     int min_package_size;
-    int gain;
 
     virtual int send_to_board (const char *msg);
     virtual int send_to_board (const char *msg, std::string &response);
@@ -28,8 +27,6 @@ class KnightBase : public Board
     virtual void read_thread () = 0;
 
 private:
-    static const std::set<int> allowed_gains;
-
 public:
     KnightBase (int board_id, struct BrainFlowInputParams params);
     virtual ~KnightBase ();

src/board_controller/neuropawn/knight.cpp

@@ -29,7 +29,7 @@ void Knight::read_thread ()
 
     int res;
     unsigned char b[20] = {0};
-    float eeg_scale = 4 / float ((pow (2, 15) - 1)) / gain * 1000000.;
+    float eeg_scale = 4 / float ((pow (2, 15) - 1)) / 12 * 1000000.;
     int num_rows = board_descr["default"]["num_rows"];
     double *package = new double[num_rows];
     for (int i = 0; i < num_rows; i++)

src/board_controller/neuropawn/knight_base.cpp

@@ -12,15 +12,13 @@ using json = nlohmann::json;
 
 constexpr int KnightBase::start_byte;
 constexpr int KnightBase::end_byte;
-const std::set<int> KnightBase::allowed_gains = {1, 2, 3, 4, 6, 8, 12};
 
 KnightBase::KnightBase (int board_id, struct BrainFlowInputParams params) : Board (board_id, params)
 {
     serial = NULL;
     is_streaming = false;
     keep_alive = false;
     initialized = false;
-    gain = 12; // default gain value
 }
 
 KnightBase::~KnightBase ()
@@ -42,46 +40,6 @@ int KnightBase::prepare_session ()
         return (int)BrainFlowExitCodes::INVALID_ARGUMENTS_ERROR;
     }
 
-    // Parse gain from other_info if provided
-    if (!params.other_info.empty ())
-    {
-        try
-        {
-            json j = json::parse (params.other_info);
-            if (j.contains ("gain"))
-            {
-                int parsed_gain = j["gain"];
-                // Validate gain is one of allowed values
-                if (allowed_gains.count (parsed_gain))
-                {
-                    gain = parsed_gain;
-                    safe_logger (spdlog::level::info, "Knight board gain set to {}", gain);
-                }
-                else
-                {
-                    safe_logger (
-                        spdlog::level::err, "Invalid gain value {} in other_info", parsed_gain);
-                    return (int)BrainFlowExitCodes::INVALID_ARGUMENTS_ERROR;
-                }
-            }
-            else
-            {
-                safe_logger (spdlog::level::info, "No gain field in other_info, using default 12");
-            }
-        }
-        catch (json::parse_error &e)
-        {
-            safe_logger (spdlog::level::err, "Failed to parse JSON from other_info: {}", e.what ());
-            return (int)BrainFlowExitCodes::INVALID_ARGUMENTS_ERROR;
-        }
-        catch (json::exception &e)
-        {
-            safe_logger (
-                spdlog::level::err, "JSON exception while parsing other_info: {}", e.what ());
-            return (int)BrainFlowExitCodes::INVALID_ARGUMENTS_ERROR;
-        }
-    }
-
     serial = Serial::create (params.serial_port.c_str (), this);
     int port_open = open_port ();
     if (port_open != (int)BrainFlowExitCodes::STATUS_OK)

src/board_controller/neuropawn/knight_imu.cpp

@@ -35,7 +35,7 @@ void KnightIMU::read_thread ()
 
     unsigned char b[frame_payload_size] = {0};
 
-    float eeg_scale = 4 / float ((pow (2, 15) - 1)) / gain * 1000000.;
+    float eeg_scale = 4 / float ((pow (2, 15) - 1)) / 12 * 1000000.;
     int num_rows = board_descr["default"]["num_rows"];
     double *package = new double[num_rows];
     for (int i = 0; i < num_rows; i++)