add names to blog post#496
Conversation
alessandrofelder
left a comment
alessandrofelder
left a comment
There was a problem hiding this comment.
I have built locally and it looks really nice 😍
One small suggestion about the newly introduced code.
I am confused why CI passes here and not on other PRs that we pushed to today, but that's for #494 😅
| linkcheck_ignore = [ | ||
| # Sphinx-gallery output files only exist after a full HTML build, not during linkcheck | ||
| ".*/*_examples/.*\.html", | ||
| r".*/*_examples/.*\.html", |
There was a problem hiding this comment.
this is just to fix this warning
it doesnt affect function
There was a problem hiding this comment.
https://github.com/brainglobe/brainglobe.github.io/actions/runs/26103449429/job/76760688334#step:2:783 you can see the warning. Its not a big deal, just something small
|
Assuming this gets merged, could we add it to the other websites with blogs? |
|
yeah absolutely. ill merge this once the tests finish and open a pr on https://github.com/neuroinformatics-unit/neuroinformatics-unit.github.io. are there other blogs? maybe movement? |
|
Yep, it's just NIU and movement, cc @niksirbi |
|
this only fails because gin is down, all good to merge? |
|
How do you know it fails because of GIN? |
I had assumed since it's a link check failure and it's complaining of a gin related time out. But maybe that's a faulty assumption
|
|
Ah OK 💡 thanks, cool, I agree now 🐌 😅 |
|
I just found out there is an alternative way of doing this, see comment. Opinions welcome! |
4 participants
closes #495
adds date and names to blog posts.
Before
After