-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Replace ProximaNova with Figtree font family #2844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,29 @@ | ||
| <style> | ||
| @font-face { | ||
| font-family: 'ProximaNova'; | ||
| src: url(fonts/ProximaNova-Regular.woff2) format('woff2'), | ||
| url(fonts/ProximaNova-Regular.woff) format('woff'); | ||
| font-family: 'Figtree'; | ||
| src: url(fonts/Figtree-Regular.woff2) format('woff2'), | ||
| url(fonts/Figtree-Regular.woff) format('woff'); | ||
| font-weight: 400; | ||
| font-style: normal; | ||
| font-display: swap; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: 'ProximaNova'; | ||
| src: url(fonts/ProximaNova-Bold.woff2) format('woff2'), | ||
| url(fonts/ProximaNova-Bold.woff) format('woff'); | ||
| font-family: 'Figtree'; | ||
| src: url(fonts/Figtree-Bold.woff2) format('woff2'), | ||
| url(fonts/Figtree-Bold.woff) format('woff'); | ||
| font-weight: 700; | ||
| font-style: normal; | ||
| font-display: swap; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: 'ProximaNova'; | ||
| src: url(fonts/ProximaNova-Black.woff2) format('woff2'), | ||
| url(fonts/ProximaNova-Black.woff) format('woff'); | ||
| font-family: 'Figtree'; | ||
| src: url(fonts/Figtree-Black.woff2) format('woff2'), | ||
| url(fonts/Figtree-Black.woff) format('woff'); | ||
| font-weight: 900; | ||
| font-style: normal; | ||
| font-display: swap; | ||
| } | ||
| </style> | ||
| <link rel="stylesheet" href="manager.css" /> | ||
| <link rel="stylesheet" href="manager.css" /> |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,9 +30,7 @@ export const getValues = function (object, addUndefined = true) { | |
|
|
||
| <PageHeader type="foundation">Typography</PageHeader> | ||
|
|
||
| The Brainly brand typeface is Proxima Nova, a geometric sans serif that works equally well with large headlines and functional copy. Use this typeface according to the following rules for consistency across the brand. | ||
|
|
||
| Proxima Nova combines modern proportions with a geometric appearance and has become one of the most popular web fonts, in use on thousands of websites around the world. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I decided to remove that paragraph since it's not relevant for now. |
||
| The Brainly brand typeface is Figtree, a geometric sans serif that works equally well with large headlines and functional copy. Use this typeface according to the following rules for consistency across the brand. | ||
|
|
||
| Our typography system is a balanced hierarchy of text styles used throughout Brainly. | ||
| This helps users quickly find information by emphasizing important parts and enhancing legibility overall. | ||
|
|
@@ -87,7 +85,7 @@ export const TextBitExamples = extraBold => { | |
| return sizesVariants; | ||
| }; | ||
|
|
||
| **Font**: Proxima Nova | ||
| **Font**: Figtree | ||
| **Weight**: 900 | ||
|
|
||
| <Typeset>{TextBitExamples(true)}</Typeset> | ||
|
|
@@ -165,12 +163,12 @@ export const HeadlineExamples = extraBold => { | |
| return sizeVariant; | ||
| }; | ||
|
|
||
| **Font**: Proxima Nova | ||
| **Font**: Figtree | ||
| **Weight**: 900 | ||
|
|
||
| <Typeset>{HeadlineExamples(true)}</Typeset> | ||
|
|
||
| **Font**: Proxima Nova | ||
| **Font**: Figtree | ||
| **Weight**: 700 | ||
|
|
||
| <Typeset>{HeadlineExamples(false)}</Typeset> | ||
|
|
@@ -316,12 +314,12 @@ export const TextExamples = weight => { | |
| return sizeVariant; | ||
| }; | ||
|
|
||
| **Font**: Proxima Nova | ||
| **Font**: Figtree | ||
| **Weight**: 700 | ||
|
|
||
| <Typeset>{TextExamples(TEXT_WEIGHT.BOLD)}</Typeset> | ||
|
|
||
| **Font**: Proxima Nova | ||
| **Font**: Figtree | ||
| **Weight**: 400 | ||
|
|
||
| <Typeset>{TextExamples(TEXT_WEIGHT.NORMAL)}</Typeset> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that after font change and now with
Figtreewe don't need additionaltop: 1px.