Skip to content

Update GitHub Actions runner to ubuntu-24.04#466

Merged
nashby merged 2 commits into
brainspec:masterfrom
snaka:fix/workflow-runner-version
Sep 10, 2025
Merged

Update GitHub Actions runner to ubuntu-24.04#466
nashby merged 2 commits into
brainspec:masterfrom
snaka:fix/workflow-runner-version

Conversation

@snaka

@snaka snaka commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Change to ubuntu-24.04 since ubuntu-20.04 is not supported in the current GitHub Acions.

Also, Rails 8.0 doesn't support Ruby 3.1.

See also:

@snaka

snaka commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

@nashby
If you are the maintainer of this repository, I would appreciate it if you could take a moment to review this PR.

Thank you.

@snaka

snaka commented Aug 27, 2025

Copy link
Copy Markdown
Contributor Author

[note]

The test that is failing in this test (the one about Rails8+) has been fixed in the following PR.
Those failing tests can be ignored for now and can be merged in.

I confirmed that tests pass by merging this PR ( #466 ) with the related PR ( #469 ).

@snaka

snaka commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

@nashby

It is helpful if you could merge this PR first, considering the following points.

The test that is failing in this test (the one about Rails8+) has been fixed in the following PR.
Those failing tests can be ignored for now and can be merged in.

If you feel that the current situation where the test is failing is undesirable, I can also include the above PR in this PR.
If you would like me to do so, please comment.

Thank you.

@nashby nashby merged commit e85714d into brainspec:master Sep 10, 2025
56 of 68 checks passed
@nashby

nashby commented Sep 10, 2025

Copy link
Copy Markdown
Member

@snaka thanks!

@snaka snaka deleted the fix/workflow-runner-version branch September 10, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants