fix: Newer rust lint

Author: brainstorm

ota/src/handler.rs

@@ -134,7 +134,7 @@ impl<W: OtaActions> UpdateProcessor<W> {
 
         debug!(
             "Decoding TLV from tlv_holder: {:?},  current_len: {}",
-            &self.tlv_holder, &self.current_len
+            self.tlv_holder, self.current_len
         );
         let mut singular_source = tlv::TlvsSource::new(&self.tlv_holder[..self.current_len]);
 

ota/src/sftpserver.rs

@@ -143,7 +143,7 @@ impl<T: OpaqueFileHandle + InitFromSeed, W: OtaActions> SftpServer<T> for SftpOt
             self.file_handle = Some(handle.clone());
             info!(
                 "SftpServer Open operation: path = {:?}, write_permission = {:?}, handle = {:?}",
-                path, self.write_permission, &handle
+                path, self.write_permission, handle
             );
             Ok(handle)
         } else {

src/config.rs

@@ -253,7 +253,7 @@ fn enc_ipv4_config(v: Option<&StaticConfigV4>, s: &mut dyn SSHSink) -> WireResul
     v.is_some().enc(s)?;
     if let Some(v) = v {
         v.address.address().to_bits().enc(s)?;
-        debug!("enc_ipv4_config: prefix = {}", &v.address.prefix_len());
+        debug!("enc_ipv4_config: prefix = {}", v.address.prefix_len());
         v.address.prefix_len().enc(s)?;
         // to u32
         let gw = v.gateway.as_ref().map(|g| g.to_bits());

src/handle.rs

@@ -175,7 +175,7 @@ pub fn session_subsystem(
             a.fail()?;
         } else if a.command()?.to_lowercase().as_str() == "sftp" {
             if let Some(ch) = ctx.session.take() {
-                debug_assert!(ch.num() == a.channel());
+                debug_assert_eq!(ch.num(), a.channel());
                 #[cfg(feature = "sftp-ota")]
                 {
                     a.succeed()?;
@@ -232,7 +232,7 @@ pub async fn session_shell<P: PlatformServices>(
                     platform.reset();
                 }
             }
-            debug_assert!(ch.num() == a.channel());
+            debug_assert_eq!(ch.num(), a.channel());
             a.succeed()?;
             debug!("We got shell");
             platform.activate_uart();

src/serve.rs

@@ -52,7 +52,7 @@ pub async fn connection_loop<P: PlatformServices>(
         let mut ph = ProgressHolder::new();
         let ev = serv.progress(&mut ph).await?;
 
-        trace!("{:?}", &ev);
+        trace!("{ev:?}");
 
         let mut ctx = EventContext {
             session: &mut session,

src/store.rs

@@ -97,7 +97,7 @@ where
 {
     let c = SSHStampConfig::new(default_mac, default_uart_pins)?;
     save(flash, buf, &c)?;
-    debug!("Created new config: {:?}", &c);
+    debug!("Created new config: {c:?}");
 
     Ok(c)
 }
@@ -157,9 +157,9 @@ where
         hash: config_hash(config)?,
     };
 
-    debug!("Before write_ssh, with hash: {}", &sc.hash.hex_dump());
+    debug!("Before write_ssh, with hash: {}", sc.hash.hex_dump());
     let l = sshwire::write_ssh(buf, &sc)?;
-    debug!("Saved flash (after write_ssh): {}", &buf[..l].hex_dump());
+    debug!("Saved flash (after write_ssh): {}", buf[..l].hex_dump());
 
     debug!(
         "CONFIG_OFFSET + FlashConfig::BUF_SIZE = {}",