Skip to content

Commit 7da6d76

Browse files
committed
Changed: Register to RegisterEval, RegisterOpts to RegisterEvalOpts
1 parent af96979 commit 7da6d76

6 files changed

Lines changed: 15 additions & 15 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ func main() {
206206
server.WithAddress("localhost:8300"),
207207
server.WithNoAuth(), // Remove for production
208208
)
209-
server.Register(srv, classify, server.RegisterOpts{})
209+
server.RegisterEval(srv, classify, server.RegisterEvalOpts{})
210210

211211
log.Fatal(srv.Start())
212212
}

examples/eval-server/eval-server.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ func main() {
5555
)
5656

5757
// Register the evaluator with the server.
58-
server.Register(srv, &eval.Eval[string, string]{
58+
server.RegisterEval(srv, &eval.Eval[string, string]{
5959
Name: "food-classifier",
6060
Task: classifyTask,
6161
Scorers: []eval.Scorer[string, string]{exactMatch},
6262
ProjectName: "go-sdk-examples",
63-
}, server.RegisterOpts{
63+
}, server.RegisterEvalOpts{
6464
Parameters: &server.Parameters{
6565
Schema: map[string]server.ParameterDef{
6666
"model": {

examples/internal/eval-server/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func main() {
7373
}
7474

7575
// Register with the server.
76-
server.Register(srv, foodClassifier, server.RegisterOpts{
76+
server.RegisterEval(srv, foodClassifier, server.RegisterEvalOpts{
7777
Parameters: &server.Parameters{
7878
Schema: map[string]server.ParameterDef{
7979
"model": {

server/register.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,16 @@ type evalRunConfig struct {
3131
tracerProvider *sdktrace.TracerProvider // nil means create per-request
3232
}
3333

34-
// RegisterOpts configures a registered evaluator.
35-
type RegisterOpts struct {
34+
// RegisterEvalOpts configures a registered evaluator.
35+
type RegisterEvalOpts struct {
3636
// Parameters defines the parameter schema shown in the Braintrust UI.
3737
Parameters *Parameters
3838

3939
// ProjectName is the default project for this evaluator.
4040
ProjectName string
4141
}
4242

43-
// Register adds an eval definition to the server. The type parameters I and R
43+
// RegisterEval adds an eval definition to the server. The type parameters I and R
4444
// are the input and result types of the evaluation. Go does not allow generic
4545
// methods on non-generic types, so this is a package-level function.
4646
//
@@ -51,8 +51,8 @@ type RegisterOpts struct {
5151
// Task: eval.T(classifyTask),
5252
// Scorers: []eval.Scorer[string, string]{scorer},
5353
// }
54-
// server.Register(srv, classify, server.RegisterOpts{})
55-
func Register[I, R any](s *Server, ev *eval.Eval[I, R], opts RegisterOpts) {
54+
// server.RegisterEval(srv, classify, server.RegisterEvalOpts{})
55+
func RegisterEval[I, R any](s *Server, ev *eval.Eval[I, R], opts RegisterEvalOpts) {
5656
impl := &registeredEvalImpl[I, R]{
5757
def: ev,
5858
opts: opts,
@@ -66,7 +66,7 @@ func Register[I, R any](s *Server, ev *eval.Eval[I, R], opts RegisterOpts) {
6666
// registeredEvalImpl implements registeredEval by wrapping an [eval.Eval] definition.
6767
type registeredEvalImpl[I, R any] struct {
6868
def *eval.Eval[I, R]
69-
opts RegisterOpts
69+
opts RegisterEvalOpts
7070
}
7171

7272
func (r *registeredEvalImpl[I, R]) scorerNames() []string {

server/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
// }
1414
//
1515
// srv := server.New(server.WithAddress(":8300"))
16-
// server.Register(srv, classify, server.RegisterOpts{})
16+
// server.RegisterEval(srv, classify, server.RegisterEvalOpts{})
1717
// log.Fatal(srv.Start())
1818
package server
1919

server/server_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ func TestListEndpoint_WithEvaluators(t *testing.T) {
5959
return eval.S(0.0), nil
6060
})
6161

62-
Register(srv, &eval.Eval[string, string]{
62+
RegisterEval(srv, &eval.Eval[string, string]{
6363
Name: "my-eval",
6464
Task: task,
6565
Scorers: []eval.Scorer[string, string]{scorer},
66-
}, RegisterOpts{})
66+
}, RegisterEvalOpts{})
6767

6868
ts := httptest.NewServer(srv.Handler())
6969
defer ts.Close()
@@ -94,11 +94,11 @@ func TestListEndpoint_WithParameters(t *testing.T) {
9494
return eval.S(1.0), nil
9595
})
9696

97-
Register(srv, &eval.Eval[string, string]{
97+
RegisterEval(srv, &eval.Eval[string, string]{
9898
Name: "param-eval",
9999
Task: task,
100100
Scorers: []eval.Scorer[string, string]{scorer},
101-
}, RegisterOpts{
101+
}, RegisterEvalOpts{
102102
Parameters: &Parameters{
103103
Schema: map[string]ParameterDef{
104104
"model": {

0 commit comments

Comments
 (0)